Refactoring: Declare cricket::Codec constructors protected.

webrtc/media/base/codec_unittest.cc

 /*
  *  Copyright (c) 2009 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/base/gunit.h"
 #include "webrtc/media/base/codec.h"
 
 using cricket::AudioCodec;
 using cricket::Codec;
 using cricket::DataCodec;
 using cricket::FeedbackParam;
 using cricket::VideoCodec;
 using cricket::kCodecParamAssociatedPayloadType;
 using cricket::kCodecParamMaxBitrate;
 using cricket::kCodecParamMinBitrate;
 
+class TestCodec : public Codec {
+ public:
+  TestCodec(int id, const std::string name, int clockrate)
+      : Codec(id, name, clockrate) {}
+  TestCodec() : Codec() {}
+  TestCodec(const TestCodec& c) : Codec(c) {}
+};
+
 TEST(CodecTest, TestCodecOperators) {
-  Codec c0(96, "D", 1000);
+  TestCodec c0(96, "D", 1000);
   c0.SetParam("a", 1);
 
-  Codec c1 = c0;
+  TestCodec c1 = c0;
   EXPECT_TRUE(c1 == c0);
 
   int param_value0;
   int param_value1;
   EXPECT_TRUE(c0.GetParam("a", &param_value0));
   EXPECT_TRUE(c1.GetParam("a", &param_value1));
   EXPECT_EQ(param_value0, param_value1);
 
   c1.id = 86;
   EXPECT_TRUE(c0 != c1);
 
   c1 = c0;
   c1.name = "x";
   EXPECT_TRUE(c0 != c1);
 
   c1 = c0;
   c1.clockrate = 2000;
   EXPECT_TRUE(c0 != c1);
 
   c1 = c0;
   c1.SetParam("a", 2);
   EXPECT_TRUE(c0 != c1);
 
-  Codec c5;
-  Codec c6(0, "", 0);
+  TestCodec c5;
+  TestCodec c6(0, "", 0);
   EXPECT_TRUE(c5 == c6);
 }
 
 TEST(CodecTest, TestAudioCodecOperators) {
   AudioCodec c0(96, "A", 44100, 20000, 2);
   AudioCodec c1(95, "A", 44100, 20000, 2);
   AudioCodec c2(96, "x", 44100, 20000, 2);
   AudioCodec c3(96, "A", 48000, 20000, 2);
   AudioCodec c4(96, "A", 44100, 10000, 2);
   AudioCodec c5(96, "A", 44100, 20000, 1);
@@ skipping 150 matching lines @@
   EXPECT_FALSE(codec.GetParam("c", &str_value));
   EXPECT_TRUE(codec.RemoveParam("a"));
   EXPECT_FALSE(codec.RemoveParam("c"));
 }
 
 TEST(CodecTest, TestIntersectFeedbackParams) {
   const FeedbackParam a1("a", "1");
   const FeedbackParam b2("b", "2");
   const FeedbackParam b3("b", "3");
   const FeedbackParam c3("c", "3");
-  Codec c1;
+  TestCodec c1;
   c1.AddFeedbackParam(a1); // Only match with c2.
   c1.AddFeedbackParam(b2); // Same param different values.
   c1.AddFeedbackParam(c3); // Not in c2.
-  Codec c2;
+  TestCodec c2;
   c2.AddFeedbackParam(a1);
   c2.AddFeedbackParam(b3);
 
   c1.IntersectFeedbackParams(c2);
   EXPECT_TRUE(c1.HasFeedbackParam(a1));
   EXPECT_FALSE(c1.HasFeedbackParam(b2));
   EXPECT_FALSE(c1.HasFeedbackParam(c3));
 }
 
 TEST(CodecTest, TestGetCodecType) {
@@ skipping 69 matching lines @@
   EXPECT_EQ(cricket::kVideoCodecClockrate, codec_params_1.clock_rate);
   EXPECT_EQ(1, codec_params_1.channels);
 
   const AudioCodec a(97, "A", 44100, 20000, 2);
   webrtc::RtpCodecParameters codec_params_2 = a.ToCodecParameters();
   EXPECT_EQ(97, codec_params_2.payload_type);
   EXPECT_EQ("A", codec_params_2.mime_type);
   EXPECT_EQ(44100, codec_params_2.clock_rate);
   EXPECT_EQ(2, codec_params_2.channels);
 }