Refactoring: Declare cricket::Codec constructors protected.

webrtc/api/webrtcsdp.cc

 /*
  *  Copyright 2011 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 2367 matching lines @@
     ParseFailed(message, *pos, "Expects m line.", error);
     return false;
   }
   return true;
 }
 
 bool VerifyCodec(const cricket::Codec& codec) {
   // Codec has not been populated correctly unless the name has been set. This
   // can happen if an SDP has an fmtp or rtcp-fb with a payload type but doesn't
   // have a corresponding "rtpmap" line.
-  cricket::Codec default_codec;
-  return default_codec.name != codec.name;
+  return !codec.name.empty();
 }
 
 bool VerifyAudioCodecs(const AudioContentDescription* audio_desc) {
   const std::vector<cricket::AudioCodec>& codecs = audio_desc->codecs();
   for (std::vector<cricket::AudioCodec>::const_iterator iter = codecs.begin();
        iter != codecs.end(); ++iter) {
     if (!VerifyCodec(*iter)) {
       return false;
     }
   }
@@ skipping 774 matching lines @@
     UpdateCodec<AudioContentDescription, cricket::AudioCodec>(
         media_desc, payload_type, feedback_param);
   } else if (media_type == cricket::MEDIA_TYPE_VIDEO) {
     UpdateCodec<VideoContentDescription, cricket::VideoCodec>(
         media_desc, payload_type, feedback_param);
   }
   return true;
 }
 
 }  // namespace webrtc