Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2546363002: Refactoring: Declare cricket::Codec constructors protected. (Closed)

Created:
4 years ago by hta-webrtc
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Refactoring: Declare cricket::Codec constructors protected. This makes it obvious that cricket::Codec should not be instantiated; only subclasses should be instantiated. BUG=none Committed: https://crrev.com/b39db841b6cd83f221f05ee5f7b91e799a4346b1 Cr-Commit-Position: refs/heads/master@{#15468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -17 lines) Patch
M webrtc/api/webrtcsdp.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/media/base/codec.h View 2 chunks +9 lines, -6 lines 0 comments Download
M webrtc/media/base/codec_unittest.cc View 3 chunks +14 lines, -6 lines 0 comments Download
M webrtc/media/sctp/sctpdataengine.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
hta-webrtc
As you can see, this one was easy.
4 years ago (2016-12-05 12:58:28 UTC) #7
magjed_webrtc
lgtm
4 years ago (2016-12-06 15:19:16 UTC) #8
hta-webrtc
Another minor change that needs an API owner approval.
4 years ago (2016-12-08 08:35:49 UTC) #10
kwiberg-webrtc
lgtm
4 years ago (2016-12-08 09:17:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2546363002/1
4 years ago (2016-12-08 09:27:17 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 09:50:52 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-08 09:50:56 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b39db841b6cd83f221f05ee5f7b91e799a4346b1
Cr-Commit-Position: refs/heads/master@{#15468}

Powered by Google App Engine
This is Rietveld 408576698