Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2546183003: Revert of Disable P2PTestConductor.LocalP2PTestDtlsBundleInIceRestart under msan (Closed)

Created:
4 years ago by Taylor Brandstetter
Modified:
4 years ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com, ossu
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Disable P2PTestConductor.LocalP2PTestDtlsBundleInIceRestart under msan (patchset #1 id:1 of https://codereview.webrtc.org/2546913003/ ) Reason for revert: Should be fixed (for good this time) by https://codereview.webrtc.org/2544003004/ Original issue's description: > Disable P2PTestConductor.LocalP2PTestDtlsBundleInIceRestart under msan > > The test is flaky. > > BUG=webrtc:6811 > TBR=deadbeef@webrtc.org > > Committed: https://crrev.com/a28a1b9db6b8b44b3687c45fddf834e81b921b20 > Cr-Commit-Position: refs/heads/master@{#15382} TBR=henrik.lundin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6811 Committed: https://crrev.com/4c6696c912de2232dd43dc44ff3939cf4658d385 Cr-Commit-Position: refs/heads/master@{#15399}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M webrtc/api/peerconnection_unittest.cc View 1 chunk +1 line, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Taylor Brandstetter
Created Revert of Disable P2PTestConductor.LocalP2PTestDtlsBundleInIceRestart under msan
4 years ago (2016-12-03 02:08:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2546183003/1
4 years ago (2016-12-03 02:08:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-03 02:09:03 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4c6696c912de2232dd43dc44ff3939cf4658d385 Cr-Commit-Position: refs/heads/master@{#15399}
4 years ago (2016-12-03 02:09:17 UTC) #7
hlundin-webrtc
4 years ago (2016-12-05 11:43:52 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698