Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2544003004: Allow locally rendered video to be downscaled in end-to-end tests. (Closed)

Created:
4 years ago by Taylor Brandstetter
Modified:
4 years ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Allow locally rendered video to be downscaled in end-to-end tests. A previous CL (https://codereview.webrtc.org/2547673002/) only did this for end-to-end rendered video. But it appears locally rendered video is downscaled too. BUG=webrtc:6811 Committed: https://crrev.com/c23efae6b28d1870c0e3ec0d954532a04ebda0ff Cr-Commit-Position: refs/heads/master@{#15397}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -18 lines) Patch
M webrtc/api/peerconnection_unittest.cc View 9 chunks +22 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Taylor Brandstetter
PTAL. The fix I did yesterday wasn't complete. Did you know that locally rendered video ...
4 years ago (2016-12-02 19:02:33 UTC) #2
pthatcher1
lgtm
4 years ago (2016-12-02 22:41:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2544003004/1
4 years ago (2016-12-02 23:23:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 23:45:34 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-02 23:45:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c23efae6b28d1870c0e3ec0d954532a04ebda0ff
Cr-Commit-Position: refs/heads/master@{#15397}

Powered by Google App Engine
This is Rietveld 408576698