Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2543723004: Remove unsupported mac framework target. (Closed)

Created:
4 years ago by kthelgason
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unsupported mac framework target. We don't have a use case for it and have no reason to support it. BUG=webrtc:6706 Committed: https://crrev.com/5fe4d496c034e9f2cae8e69c41b2a274f87b399d Cr-Commit-Position: refs/heads/master@{#15428}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -86 lines) Patch
M webrtc/sdk/BUILD.gn View 2 chunks +41 lines, -86 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
kthelgason
4 years ago (2016-12-01 13:35:59 UTC) #2
magjed_webrtc
lgtm
4 years ago (2016-12-01 13:50:07 UTC) #5
tkchin_webrtc
On 2016/12/01 13:50:07, magjed_webrtc wrote: > lgtm lgtm can you check that mac builder builds ...
4 years ago (2016-12-02 21:42:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2543723004/1
4 years ago (2016-12-05 19:11:33 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 19:27:33 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-05 19:27:43 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5fe4d496c034e9f2cae8e69c41b2a274f87b399d
Cr-Commit-Position: refs/heads/master@{#15428}

Powered by Google App Engine
This is Rietveld 408576698