Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1503)

Issue 2542983002: webrtc: Remove dependency on xdisplaycheck (Closed)

Created:
4 years ago by Tom (Use chromium acct)
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

webrtc: Remove dependency on xdisplaycheck BUG=670470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M webrtc/test/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
Tom (Use chromium acct)
4 years ago (2016-12-01 19:38:26 UTC) #2
Dirk Pranke
4 years ago (2016-12-01 20:43:35 UTC) #4
Dirk Pranke
lgtm. To kjellander@ for actual approval.
4 years ago (2016-12-01 20:43:53 UTC) #5
kjellander_webrtc
4 years ago (2016-12-02 06:46:16 UTC) #15
On 2016/12/01 20:43:53, Dirk Pranke wrote:
> lgtm. To kjellander@ for actual approval.

We currently depend on xdisplaycheck similar to Chromium:
https://cs.chromium.org/chromium/src/tools/mb/mb.py?rcl=0&l=1106 since it's used
for tests that runs with a Window environment.
I triggered a clobbered tryjob for this CL using: git cl try --bot=linux_rel
--clobber -m tryserver.webrtc
and as you can see in
https://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/20863
it's failing.

After removing it from our mb.py copy, it seems to work though, so I created
https://codereview.webrtc.org/2548763002/
I'm closing this CL in favor for that one.

Powered by Google App Engine
This is Rietveld 408576698