Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2542843003: Remove bitrate cap for AdaptiveVideoSource and increase other caps to 25 Mbps. (Closed)

Created:
4 years ago by terelius
Modified:
4 years ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove bitrate cap for AdaptiveVideoSource and increase other caps to 25 Mbps. AdaptiveVideoSource is used in testing/simulations of the bandwidth estimator. Nada's reaction to delay depends on the current bitrate and the configured max rate in a non-intuituve way. Increase the starting bitrate to compensate for the increased max bitrate. This is only used in unit tests. BUG=webrtc:6807 # Presubmit warns about a lint error in bwe.h that's unrelated to my change. Fixing it is beyond the scope of this CL. NOPRESUBMIT=true Committed: https://crrev.com/182e4a4aff7125e2e9e3217b253bc4d1545f8bce Cr-Commit-Position: refs/heads/master@{#15364}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M webrtc/modules/remote_bitrate_estimator/test/bwe.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/nada_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
terelius
4 years ago (2016-12-01 14:36:19 UTC) #2
stefan-webrtc
lgtm
4 years ago (2016-12-01 14:43:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2542843003/1
4 years ago (2016-12-01 14:45:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10940)
4 years ago (2016-12-01 14:47:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2542843003/1
4 years ago (2016-12-01 15:27:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 15:29:12 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-01 15:29:20 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/182e4a4aff7125e2e9e3217b253bc4d1545f8bce
Cr-Commit-Position: refs/heads/master@{#15364}

Powered by Google App Engine
This is Rietveld 408576698