Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: webrtc/call/flexfec_receive_stream_unittest.cc

Issue 2542413002: Generalize FlexfecReceiveStream::Config. (CL1) (Closed)
Patch Set: Rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/call/flexfec_receive_stream.cc ('k') | webrtc/media/engine/webrtcvideoengine2.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/base/basictypes.h" 11 #include "webrtc/base/basictypes.h"
12 #include "webrtc/call/flexfec_receive_stream.h" 12 #include "webrtc/call/flexfec_receive_stream.h"
13 #include "webrtc/modules/rtp_rtcp/include/flexfec_receiver.h" 13 #include "webrtc/modules/rtp_rtcp/include/flexfec_receiver.h"
14 #include "webrtc/modules/rtp_rtcp/source/byte_io.h" 14 #include "webrtc/modules/rtp_rtcp/source/byte_io.h"
15 #include "webrtc/modules/rtp_rtcp/mocks/mock_recovered_packet_receiver.h" 15 #include "webrtc/modules/rtp_rtcp/mocks/mock_recovered_packet_receiver.h"
16 #include "webrtc/test/gmock.h" 16 #include "webrtc/test/gmock.h"
17 #include "webrtc/test/gtest.h" 17 #include "webrtc/test/gtest.h"
18 18
19 namespace webrtc { 19 namespace webrtc {
20 20
21 TEST(FlexfecReceiveStreamTest, ConstructDestruct) { 21 TEST(FlexfecReceiveStreamTest, ConstructDestruct) {
22 FlexfecReceiveStream::Config config; 22 FlexfecReceiveStream::Config config;
23 config.flexfec_payload_type = 118; 23 config.payload_type = 118;
24 config.flexfec_ssrc = 424223; 24 config.remote_ssrc = 424223;
25 config.protected_media_ssrcs = {912512}; 25 config.protected_media_ssrcs = {912512};
26 MockRecoveredPacketReceiver callback; 26 MockRecoveredPacketReceiver callback;
27 27
28 internal::FlexfecReceiveStream receive_stream(config, &callback); 28 internal::FlexfecReceiveStream receive_stream(config, &callback);
29 } 29 }
30 30
31 TEST(FlexfecReceiveStreamTest, StartStop) { 31 TEST(FlexfecReceiveStreamTest, StartStop) {
32 FlexfecReceiveStream::Config config; 32 FlexfecReceiveStream::Config config;
33 config.flexfec_payload_type = 118; 33 config.payload_type = 118;
34 config.flexfec_ssrc = 1652392; 34 config.remote_ssrc = 1652392;
35 config.protected_media_ssrcs = {23300443}; 35 config.protected_media_ssrcs = {23300443};
36 MockRecoveredPacketReceiver callback; 36 MockRecoveredPacketReceiver callback;
37 internal::FlexfecReceiveStream receive_stream(config, &callback); 37 internal::FlexfecReceiveStream receive_stream(config, &callback);
38 38
39 receive_stream.Start(); 39 receive_stream.Start();
40 receive_stream.Stop(); 40 receive_stream.Stop();
41 } 41 }
42 42
43 TEST(FlexfecReceiveStreamTest, DoesNotProcessPacketWhenNoMediaSsrcGiven) { 43 TEST(FlexfecReceiveStreamTest, DoesNotProcessPacketWhenNoMediaSsrcGiven) {
44 FlexfecReceiveStream::Config config; 44 FlexfecReceiveStream::Config config;
45 config.flexfec_payload_type = 118; 45 config.payload_type = 118;
46 config.flexfec_ssrc = 424223; 46 config.remote_ssrc = 424223;
47 config.protected_media_ssrcs = {}; 47 config.protected_media_ssrcs = {};
48 MockRecoveredPacketReceiver callback; 48 MockRecoveredPacketReceiver callback;
49 internal::FlexfecReceiveStream receive_stream(config, &callback); 49 internal::FlexfecReceiveStream receive_stream(config, &callback);
50 const uint8_t packet[] = {0x00, 0x11, 0x22, 0x33}; 50 const uint8_t packet[] = {0x00, 0x11, 0x22, 0x33};
51 const size_t packet_length = sizeof(packet); 51 const size_t packet_length = sizeof(packet);
52 52
53 EXPECT_FALSE( 53 EXPECT_FALSE(
54 receive_stream.AddAndProcessReceivedPacket(packet, packet_length)); 54 receive_stream.AddAndProcessReceivedPacket(packet, packet_length));
55 } 55 }
56 56
(...skipping 30 matching lines...) Expand all
87 kMediaTs[0], kMediaTs[1], kMediaTs[2], kMediaTs[3], 87 kMediaTs[0], kMediaTs[1], kMediaTs[2], kMediaTs[3],
88 kSsrcCount, kReservedBits, kReservedBits, kReservedBits, 88 kSsrcCount, kReservedBits, kReservedBits, kReservedBits,
89 kMediaSsrc[0], kMediaSsrc[1], kMediaSsrc[2], kMediaSsrc[3], 89 kMediaSsrc[0], kMediaSsrc[1], kMediaSsrc[2], kMediaSsrc[3],
90 kMediaSeqNum[0], kMediaSeqNum[1], kFlexfecPktMask[0], kFlexfecPktMask[1], 90 kMediaSeqNum[0], kMediaSeqNum[1], kFlexfecPktMask[0], kFlexfecPktMask[1],
91 // FEC payload. 91 // FEC payload.
92 kPayloadBits, kPayloadBits, kPayloadBits, kPayloadBits}; 92 kPayloadBits, kPayloadBits, kPayloadBits, kPayloadBits};
93 // clang-format on 93 // clang-format on
94 constexpr size_t kFlexfecPacketLength = sizeof(kFlexfecPacket); 94 constexpr size_t kFlexfecPacketLength = sizeof(kFlexfecPacket);
95 95
96 FlexfecReceiveStream::Config config; 96 FlexfecReceiveStream::Config config;
97 config.flexfec_payload_type = kFlexfecPlType; 97 config.payload_type = kFlexfecPlType;
98 config.flexfec_ssrc = ByteReader<uint32_t>::ReadBigEndian(kFlexfecSsrc); 98 config.remote_ssrc = ByteReader<uint32_t>::ReadBigEndian(kFlexfecSsrc);
99 config.protected_media_ssrcs = { 99 config.protected_media_ssrcs = {
100 ByteReader<uint32_t>::ReadBigEndian(kMediaSsrc)}; 100 ByteReader<uint32_t>::ReadBigEndian(kMediaSsrc)};
101 testing::StrictMock<MockRecoveredPacketReceiver> recovered_packet_receiver; 101 testing::StrictMock<MockRecoveredPacketReceiver> recovered_packet_receiver;
102 internal::FlexfecReceiveStream receive_stream(config, 102 internal::FlexfecReceiveStream receive_stream(config,
103 &recovered_packet_receiver); 103 &recovered_packet_receiver);
104 104
105 // Do not call back before being started. 105 // Do not call back before being started.
106 receive_stream.AddAndProcessReceivedPacket(kFlexfecPacket, 106 receive_stream.AddAndProcessReceivedPacket(kFlexfecPacket,
107 kFlexfecPacketLength); 107 kFlexfecPacketLength);
108 108
109 // Call back after being started. 109 // Call back after being started.
110 receive_stream.Start(); 110 receive_stream.Start();
111 EXPECT_CALL( 111 EXPECT_CALL(
112 recovered_packet_receiver, 112 recovered_packet_receiver,
113 OnRecoveredPacket(::testing::_, kRtpHeaderSize + kPayloadLength[1])); 113 OnRecoveredPacket(::testing::_, kRtpHeaderSize + kPayloadLength[1]));
114 receive_stream.AddAndProcessReceivedPacket(kFlexfecPacket, 114 receive_stream.AddAndProcessReceivedPacket(kFlexfecPacket,
115 kFlexfecPacketLength); 115 kFlexfecPacketLength);
116 } 116 }
117 117
118 } // namespace webrtc 118 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/call/flexfec_receive_stream.cc ('k') | webrtc/media/engine/webrtcvideoengine2.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698