Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Side by Side Diff: webrtc/video/end_to_end_tests.cc

Issue 2542413002: Generalize FlexfecReceiveStream::Config. (CL1) (Closed)
Patch Set: philipel response 1. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include <algorithm> 10 #include <algorithm>
(...skipping 3815 matching lines...) Expand 10 before | Expand all | Expand 10 after
3826 << "Enabling ULPFEC requires rtpmap: ulpfec negotiation."; 3826 << "Enabling ULPFEC requires rtpmap: ulpfec negotiation.";
3827 EXPECT_EQ(-1, config.red_payload_type) 3827 EXPECT_EQ(-1, config.red_payload_type)
3828 << "Enabling ULPFEC requires rtpmap: red negotiation."; 3828 << "Enabling ULPFEC requires rtpmap: red negotiation.";
3829 EXPECT_EQ(-1, config.red_rtx_payload_type) 3829 EXPECT_EQ(-1, config.red_rtx_payload_type)
3830 << "Enabling RTX in ULPFEC requires rtpmap: rtx negotiation."; 3830 << "Enabling RTX in ULPFEC requires rtpmap: rtx negotiation.";
3831 } 3831 }
3832 3832
3833 void VerifyEmptyFlexfecConfig(const FlexfecConfig& config) { 3833 void VerifyEmptyFlexfecConfig(const FlexfecConfig& config) {
3834 EXPECT_EQ(-1, config.flexfec_payload_type) 3834 EXPECT_EQ(-1, config.flexfec_payload_type)
3835 << "Enabling FlexFEC requires rtpmap: flexfec negotiation."; 3835 << "Enabling FlexFEC requires rtpmap: flexfec negotiation.";
3836 EXPECT_EQ(0U, config.flexfec_ssrc)
3837 << "Enabling FlexFEC requires ssrc-group: FEC-FR negotiation.";
3836 EXPECT_TRUE(config.protected_media_ssrcs.empty()) 3838 EXPECT_TRUE(config.protected_media_ssrcs.empty())
3837 << "Enabling FlexFEC requires ssrc-group: FEC-FR negotiation."; 3839 << "Enabling FlexFEC requires ssrc-group: FEC-FR negotiation.";
3838 } 3840 }
3839 3841
3840 TEST_P(EndToEndTest, VerifyDefaultSendConfigParameters) { 3842 TEST_P(EndToEndTest, VerifyDefaultSendConfigParameters) {
3841 VideoSendStream::Config default_send_config(nullptr); 3843 VideoSendStream::Config default_send_config(nullptr);
3842 EXPECT_EQ(0, default_send_config.rtp.nack.rtp_history_ms) 3844 EXPECT_EQ(0, default_send_config.rtp.nack.rtp_history_ms)
3843 << "Enabling NACK require rtcp-fb: nack negotiation."; 3845 << "Enabling NACK require rtcp-fb: nack negotiation.";
3844 EXPECT_TRUE(default_send_config.rtp.rtx.ssrcs.empty()) 3846 EXPECT_TRUE(default_send_config.rtp.rtx.ssrcs.empty())
3845 << "Enabling RTX requires rtpmap: rtx negotiation."; 3847 << "Enabling RTX requires rtpmap: rtx negotiation.";
(...skipping 18 matching lines...) Expand all
3864 << "Enabling RTX requires rtpmap: rtx negotiation."; 3866 << "Enabling RTX requires rtpmap: rtx negotiation.";
3865 EXPECT_TRUE(default_receive_config.rtp.extensions.empty()) 3867 EXPECT_TRUE(default_receive_config.rtp.extensions.empty())
3866 << "Enabling RTP extensions require negotiation."; 3868 << "Enabling RTP extensions require negotiation.";
3867 3869
3868 VerifyEmptyNackConfig(default_receive_config.rtp.nack); 3870 VerifyEmptyNackConfig(default_receive_config.rtp.nack);
3869 VerifyEmptyUlpfecConfig(default_receive_config.rtp.ulpfec); 3871 VerifyEmptyUlpfecConfig(default_receive_config.rtp.ulpfec);
3870 } 3872 }
3871 3873
3872 TEST_P(EndToEndTest, VerifyDefaultFlexfecReceiveConfigParameters) { 3874 TEST_P(EndToEndTest, VerifyDefaultFlexfecReceiveConfigParameters) {
3873 FlexfecReceiveStream::Config default_receive_config; 3875 FlexfecReceiveStream::Config default_receive_config;
3874 VerifyEmptyFlexfecConfig(default_receive_config); 3876 EXPECT_EQ(-1, default_receive_config.payload_type)
3877 << "Enabling FlexFEC requires rtpmap: flexfec negotiation.";
3878 EXPECT_EQ(0U, default_receive_config.remote_ssrc)
3879 << "Enabling FlexFEC requires ssrc-group: FEC-FR negotiation.";
3880 EXPECT_TRUE(default_receive_config.protected_media_ssrcs.empty())
3881 << "Enabling FlexFEC requires ssrc-group: FEC-FR negotiation.";
3875 } 3882 }
3876 3883
3877 TEST_P(EndToEndTest, TransportSeqNumOnAudioAndVideo) { 3884 TEST_P(EndToEndTest, TransportSeqNumOnAudioAndVideo) {
3878 static const int kExtensionId = 8; 3885 static const int kExtensionId = 8;
3879 class TransportSequenceNumberTest : public test::EndToEndTest { 3886 class TransportSequenceNumberTest : public test::EndToEndTest {
3880 public: 3887 public:
3881 TransportSequenceNumberTest() 3888 TransportSequenceNumberTest()
3882 : EndToEndTest(kDefaultTimeoutMs), 3889 : EndToEndTest(kDefaultTimeoutMs),
3883 video_observed_(false), 3890 video_observed_(false),
3884 audio_observed_(false) { 3891 audio_observed_(false) {
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
4041 std::unique_ptr<VideoEncoder> encoder_; 4048 std::unique_ptr<VideoEncoder> encoder_;
4042 std::unique_ptr<VideoDecoder> decoder_; 4049 std::unique_ptr<VideoDecoder> decoder_;
4043 rtc::CriticalSection crit_; 4050 rtc::CriticalSection crit_;
4044 int recorded_frames_ GUARDED_BY(crit_); 4051 int recorded_frames_ GUARDED_BY(crit_);
4045 } test(this); 4052 } test(this);
4046 4053
4047 RunBaseTest(&test); 4054 RunBaseTest(&test);
4048 } 4055 }
4049 4056
4050 } // namespace webrtc 4057 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698