Relaxing DCHECK for packets sent before SRTP is enabled.

Relaxing DCHECK for packets sent before SRTP is enabled.

We still DCHECK for RTP, but not RTCP. RTCP packets can be sent before
offer/answer negotiation is complete, due to this bug:
https://bugs.chromium.org/p/webrtc/issues/detail?id=6809

This bug can only occur if the RTCP mux policy is "require", which is
why we started hitting it recently (the default in unit tests was
recently changed to "require").

BUG=webrtc:6776
TBR=pthatcher@webrtc.org

Committed: https://crrev.com/8f425f9629636e82749f3e3e5a6e524d947bf750
Cr-Commit-Position: refs/heads/master@{#15369}

[Taylor Brandstetter, 2016-12-01 19:49:00]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[Taylor Brandstetter, 2016-12-01 19:49:01]

PTAL again Peter. It turns out the root issue is more complicated than I
thought, so I'm just going to relax the DCHECK so our tests can keep running.
The actual bug is pretty minor and has existed for a long time (as far as I can
tell).

[Taylor Brandstetter, 2016-12-01 20:10:57]

Description was changed from

==========
Relaxing DCHECK for packets sent before SRTP is enabled.

We still DCHECK for RTP, but not RTCP. RTCP packets can be sent before
offer/answer negotiation is complete, due to this bug:
https://bugs.chromium.org/p/webrtc/issues/detail?id=6809

This bug can only occur if the RTCP mux policy is "require", which is
why we started hitting it recently (the default in unit tests was
recently changed to "require").

BUG=webrtc:6776
==========

to

==========
Relaxing DCHECK for packets sent before SRTP is enabled.

We still DCHECK for RTP, but not RTCP. RTCP packets can be sent before
offer/answer negotiation is complete, due to this bug:
https://bugs.chromium.org/p/webrtc/issues/detail?id=6809

This bug can only occur if the RTCP mux policy is "require", which is
why we started hitting it recently (the default in unit tests was
recently changed to "require").

BUG=webrtc:6776
TBR=pthatcher@webrtc.org
==========

[Taylor Brandstetter, 2016-12-01 20:11:04]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2016-12-01 20:11:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-01 20:26:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480623064996670, "parent_rev":
"3b7c0c05dbd4f786027954073b1ee7825746ab51", "commit_rev":
"90d4453c7dabdf6b852bb3c2131c8542fd26c67d"}

[commit-bot: I haz the power, 2016-12-01 20:26:30]

Description was changed from

==========
Relaxing DCHECK for packets sent before SRTP is enabled.

We still DCHECK for RTP, but not RTCP. RTCP packets can be sent before
offer/answer negotiation is complete, due to this bug:
https://bugs.chromium.org/p/webrtc/issues/detail?id=6809

This bug can only occur if the RTCP mux policy is "require", which is
why we started hitting it recently (the default in unit tests was
recently changed to "require").

BUG=webrtc:6776
TBR=pthatcher@webrtc.org
==========

to

==========
Relaxing DCHECK for packets sent before SRTP is enabled.

We still DCHECK for RTP, but not RTCP. RTCP packets can be sent before
offer/answer negotiation is complete, due to this bug:
https://bugs.chromium.org/p/webrtc/issues/detail?id=6809

This bug can only occur if the RTCP mux policy is "require", which is
why we started hitting it recently (the default in unit tests was
recently changed to "require").

BUG=webrtc:6776
TBR=pthatcher@webrtc.org
==========

[commit-bot: I haz the power, 2016-12-01 20:26:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-01 20:26:39]

Description was changed from

==========
Relaxing DCHECK for packets sent before SRTP is enabled.

We still DCHECK for RTP, but not RTCP. RTCP packets can be sent before
offer/answer negotiation is complete, due to this bug:
https://bugs.chromium.org/p/webrtc/issues/detail?id=6809

This bug can only occur if the RTCP mux policy is "require", which is
why we started hitting it recently (the default in unit tests was
recently changed to "require").

BUG=webrtc:6776
TBR=pthatcher@webrtc.org
==========

to

==========
Relaxing DCHECK for packets sent before SRTP is enabled.

We still DCHECK for RTP, but not RTCP. RTCP packets can be sent before
offer/answer negotiation is complete, due to this bug:
https://bugs.chromium.org/p/webrtc/issues/detail?id=6809

This bug can only occur if the RTCP mux policy is "require", which is
why we started hitting it recently (the default in unit tests was
recently changed to "require").

BUG=webrtc:6776
TBR=pthatcher@webrtc.org

Committed: https://crrev.com/8f425f9629636e82749f3e3e5a6e524d947bf750
Cr-Commit-Position: refs/heads/master@{#15369}
==========

[commit-bot: I haz the power, 2016-12-01 20:26:40]

Patchset 1 (id:??) landed as
https://crrev.com/8f425f9629636e82749f3e3e5a6e524d947bf750
Cr-Commit-Position: refs/heads/master@{#15369}

[pthatcher1, 2016-12-01 22:51:36]

lgtm