Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: webrtc/modules/video_coding/generic_encoder.cc

Issue 2541863002: Delete VideoFrame default constructor, and IsZeroSize method. (Closed)
Patch Set: Initialize pixel data in VideoBroadcasterTest.OnFrame test. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/generic_encoder.cc
diff --git a/webrtc/modules/video_coding/generic_encoder.cc b/webrtc/modules/video_coding/generic_encoder.cc
index 75bdc7c4f39c534b62270b537d23e6bb43559d8a..1786e72ea26009207fe40a94b66e77b9d05099b2 100644
--- a/webrtc/modules/video_coding/generic_encoder.cc
+++ b/webrtc/modules/video_coding/generic_encoder.cc
@@ -123,8 +123,14 @@ int32_t VCMGenericEncoder::SetPeriodicKeyFrames(bool enable) {
int32_t VCMGenericEncoder::RequestFrame(
const std::vector<FrameType>& frame_types) {
RTC_DCHECK_RUNS_SERIALIZED(&race_checker_);
- VideoFrame image;
- return encoder_->Encode(image, NULL, &frame_types);
+
+ // TODO(nisse): Used only with internal source. Delete as soon as
+ // that feature is removed. The only implementation I've been able
+ // to find ignores what's in the frame.
+ return encoder_->Encode(VideoFrame(I420Buffer::Create(1, 1),
+ kVideoRotation_0, 0),
+ NULL, &frame_types);
+ return 0;
}
bool VCMGenericEncoder::InternalSource() const {
« no previous file with comments | « webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc ('k') | webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698