Delete VideoFrame default constructor, and IsZeroSize method.

webrtc/modules/video_coding/generic_encoder.cc

 /*
 *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
 *
 *  Use of this source code is governed by a BSD-style license
 *  that can be found in the LICENSE file in the root of the source
 *  tree. An additional intellectual property rights grant can be found
 *  in the file PATENTS.  All contributing project authors may
 *  be found in the AUTHORS file in the root of the source tree.
 */
 
@@ skipping 105 matching lines @@
 }
 
 int32_t VCMGenericEncoder::SetPeriodicKeyFrames(bool enable) {
   RTC_DCHECK_RUNS_SERIALIZED(&race_checker_);
   return encoder_->SetPeriodicKeyFrames(enable);
 }
 
 int32_t VCMGenericEncoder::RequestFrame(
     const std::vector<FrameType>& frame_types) {
   RTC_DCHECK_RUNS_SERIALIZED(&race_checker_);
-  VideoFrame image;
-  return encoder_->Encode(image, NULL, &frame_types);
+
+  // TODO(nisse): Used only with internal source. Delete as soon as
+  // that feature is removed. The only implementation I've been able
+  // to find ignores what's in the frame.
+  return encoder_->Encode(VideoFrame(I420Buffer::Create(1, 1),

[magjed_webrtc, 2016/11/30 16:23:56]

This looks very strange. What's the purpose here?

[nisse-webrtc, 2016/11/30 16:36:00]

The way I understand it, when the "internal source" hack is used, normal video
frames are never sent to the Encode method, because the encoder is hooked up
directly to the camera in some way, perhaps the source produces encoded frames
directly.

But since that's the only way to get the key frame request signal across the
encoder interface, the encoder object for that case implements an Encode method
which examines the frame_type argument, and ignores the frame.

This was the smallest change to make that ugly hack still work (it used to pass
a VideoFrame where video_frame_buffer() is null)). The right way would probably
be to add an encoder method specifically for keyframe request signalling. But
that's a refactoring unrelated to this cl.

[magjed_webrtc, 2016/12/01 11:46:38]

Acknowledged.

+                                     kVideoRotation_0, 0),
+                          NULL, &frame_types);
+  return 0;

[nisse-webrtc, 2016/11/30 16:36:00]

But this extra return statement looks very wrong.

 }
 
 bool VCMGenericEncoder::InternalSource() const {
   return internal_source_;
 }
 
 bool VCMGenericEncoder::SupportsNativeHandle() const {
   RTC_DCHECK_RUNS_SERIALIZED(&race_checker_);
   return encoder_->SupportsNativeHandle();
 }
@@ skipping 22 matching lines @@
     media_opt_->UpdateWithEncodedData(encoded_image);
     if (internal_source_) {
       // Signal to encoder to drop next frame.
       result.drop_next_frame = media_opt_->DropFrame();
     }
   }
   return result;
 }
 
 }  // namespace webrtc