Move webrtc/api/androidtests to webrtc/sdk/android/instrumentationtests

webrtc/sdk/android/instrumentationtests/BUILD.gn

Index: webrtc/sdk/android/instrumentationtests/BUILD.gn
diff --git a/webrtc/sdk/android/instrumentationtests/BUILD.gn b/webrtc/sdk/android/instrumentationtests/BUILD.gn
new file mode 100644
index 0000000000000000000000000000000000000000..0523b39bef8d3ffee5f828fd456197bd61bc304c
--- /dev/null
+++ b/webrtc/sdk/android/instrumentationtests/BUILD.gn
@@ -0,0 +1,43 @@
+# Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
+#
+# Use of this source code is governed by a BSD-style license
+# that can be found in the LICENSE file in the root of the source
+# tree. An additional intellectual property rights grant can be found
+# in the file PATENTS.  All contributing project authors may
+# be found in the AUTHORS file in the root of the source tree.
+
+import("../../../build/webrtc.gni")
+import("//build/config/android/config.gni")
+import("//build/config/android/rules.gni")
+
+if (rtc_include_tests) {
+  instrumentation_test_apk("libjingle_peerconnection_android_unittest") {

[sakal, 2016/11/30 14:21:30]

Most BUILD files should have a target with the same name of the directory. This
target should be the first target.

However, it might not be the right thing to rename this to the directory name:
Executables and tests should be given a globally unique name. Technically only
the output names must be unique, but since only the output names appear in the
shell and on bots, it's much less confusing if the name matches the other places
the executable appears.

So back to to groups?

[kjellander_webrtc, 2016/11/30 14:37:08]

I agree we shouldn't have neither 'android' or 'instrumentationtests' as group
names.
I suggest just put this into the webrtc/sdk/BUILD.gn file instead. 

[magjed_webrtc, 2016/11/30 15:15:36]

I would also prefer to have smaller BUILD files closer to the code so it's more
modular, but I'm a GN noob so I don't know the pros and cons of this.

[kjellander_webrtc, 2016/11/30 18:41:54]

I can't think of any significant pros and cons so please go ahead with this.

+    apk_name = "libjingle_peerconnection_android_unittest"
+    android_manifest = "AndroidManifest.xml"
+
+    java_files = [
+      "src/org/webrtc/Camera1CapturerUsingByteBufferTest.java",
+      "src/org/webrtc/Camera1CapturerUsingTextureTest.java",
+      "src/org/webrtc/Camera2CapturerTest.java",
+      "src/org/webrtc/CameraVideoCapturerTestFixtures.java",
+      "src/org/webrtc/EglRendererTest.java",
+      "src/org/webrtc/GlRectDrawerTest.java",
+      "src/org/webrtc/MediaCodecVideoEncoderTest.java",
+      "src/org/webrtc/NetworkMonitorTest.java",
+      "src/org/webrtc/PeerConnectionTest.java",
+      "src/org/webrtc/RendererCommonTest.java",
+      "src/org/webrtc/SurfaceTextureHelperTest.java",
+      "src/org/webrtc/SurfaceViewRendererOnMeasureTest.java",
+      "src/org/webrtc/WebRtcJniBootTest.java",
+    ]
+
+    deps = [
+      "../../../api:libjingle_peerconnection_java",
+      "../../../api:libjingle_peerconnection_metrics_default_java",
+      "../../../base:base_java",
+      "//base:base_java",
+    ]
+
+    shared_libraries = [ "../../../api:libjingle_peerconnection_so" ]
+  }
+}