Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2541743006: Increase test timeout to combat flakiness. (Closed)

Created:
4 years ago by kthelgason
Modified:
4 years ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Increase test timeout to combat flakiness. These tests have been a little flaky on the bots. Hopefully increasing the timeout by 200% will help. BUG=webrtc:6799 Committed: https://crrev.com/86cf9a2474fd1bddacf16f59bd543b85d231b3ef Cr-Commit-Position: refs/heads/master@{#15355}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Set timeout in constant #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M webrtc/modules/video_coding/utility/quality_scaler_unittest.cc View 1 4 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
kthelgason
4 years ago (2016-12-01 09:28:59 UTC) #2
sprang_webrtc
lgtm % nit https://codereview.webrtc.org/2541743006/diff/1/webrtc/modules/video_coding/utility/quality_scaler_unittest.cc File webrtc/modules/video_coding/utility/quality_scaler_unittest.cc (right): https://codereview.webrtc.org/2541743006/diff/1/webrtc/modules/video_coding/utility/quality_scaler_unittest.cc#newcode113 webrtc/modules/video_coding/utility/quality_scaler_unittest.cc:113: EXPECT_TRUE(observer_->event.Wait(150)); Please add a kDefaultTimeoutsMs constant ...
4 years ago (2016-12-01 10:06:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2541743006/20001
4 years ago (2016-12-01 10:26:16 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 10:57:04 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-01 10:57:14 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/86cf9a2474fd1bddacf16f59bd543b85d231b3ef
Cr-Commit-Position: refs/heads/master@{#15355}

Powered by Google App Engine
This is Rietveld 408576698