Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 2541583003: RtpDataEngine, FindCodecByName: Don't reassign codecs (Closed)

Created:
4 years ago by magjed_webrtc
Modified:
4 years ago
Reviewers:
hta-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

RtpDataEngine, FindCodecByName: Don't reassign codecs BUG=None Committed: https://crrev.com/b49fc142e303e294acbf5a8f04a9b97aa7468750 Cr-Commit-Position: refs/heads/master@{#15327}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M webrtc/media/base/rtpdataengine.cc View 4 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
magjed_webrtc
Harald - please take a look. This CL removes one unnecessary codec assignment.
4 years ago (2016-11-30 11:52:06 UTC) #5
hta-webrtc
lgtm If this had been a publicly exposed API function, I'd have worried about the ...
4 years ago (2016-11-30 12:00:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2541583003/1
4 years ago (2016-11-30 12:49:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 12:52:06 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-30 12:52:15 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b49fc142e303e294acbf5a8f04a9b97aa7468750
Cr-Commit-Position: refs/heads/master@{#15327}

Powered by Google App Engine
This is Rietveld 408576698