Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2541303003: Wire up BitrateAllocation to be sent as RTCP TargetBitrate (Closed)

Created:
4 years ago by sprang_webrtc
Modified:
4 years ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Wire up BitrateAllocation to be sent as RTCP TargetBitrate This is the video parts of https://codereview.webrtc.org/2531383002/ Wire up BitrateAllocation to be sent as RTCP TargetBitrate BUG=webrtc:6301 Committed: https://crrev.com/1a646ee522d614dc19b3022b8857cc1a37ec47b4 Cr-Commit-Position: refs/heads/master@{#15359}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -138 lines) Patch
M webrtc/common_video/include/video_bitrate_allocator.h View 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.h View 2 chunks +18 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/video_sender.cc View 3 chunks +21 lines, -10 lines 0 comments Download
M webrtc/modules/video_coding/video_sender_unittest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 3 chunks +91 lines, -88 lines 0 comments Download
M webrtc/video/payload_router.h View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/video/payload_router.cc View 3 chunks +22 lines, -2 lines 0 comments Download
M webrtc/video/payload_router_unittest.cc View 6 chunks +53 lines, -5 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 11 chunks +19 lines, -10 lines 0 comments Download
M webrtc/video/vie_encoder.h View 3 chunks +5 lines, -0 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 7 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
sprang_webrtc
4 years ago (2016-12-01 13:33:09 UTC) #4
stefan-webrtc
lgtm
4 years ago (2016-12-01 14:31:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2541303003/1
4 years ago (2016-12-01 14:32:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 14:34:15 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-01 14:34:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a646ee522d614dc19b3022b8857cc1a37ec47b4
Cr-Commit-Position: refs/heads/master@{#15359}

Powered by Google App Engine
This is Rietveld 408576698