Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2541163007:
VP8DecoderImpl: Fix uninitialized memory crash (Closed)
|
Created:
4 years ago by magjed_webrtc Modified:
4 years ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionVP8DecoderImpl: Fix uninitialized memory crash
It is not safe to call vpx_codec_destroy if vpx_codec_dec_init failed,
because the |decoder_| memory will be uninitialized. See the bug for
more info.
BUG=chromium:663293
Committed: https://crrev.com/5c71166dffb49510092bf87f271b6ea590acd1f1
Cr-Commit-Position: refs/heads/master@{#15381}
Patch Set 1 #
Messages
Total messages: 17 (11 generated)
The CQ bit was checked by magjed@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== VP8DecoderImpl: Fix uninitialized memory crash BUG=chromium:663293 ========== to ========== VP8DecoderImpl: Fix uninitialized memory crash It is not safe to call vpx_codec_destroy if vpx_codec_dec_init failed, because the |decoder_| memory will be uninitialized. See the bug for more info. BUG=chromium:663293 ==========
magjed@webrtc.org changed reviewers: + tommi@webrtc.org
Tommi - please take a look.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm! Thanks for fixing this so quickly.
The CQ bit was checked by magjed@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
mflodman@webrtc.org changed reviewers: + mflodman@webrtc.org
Thanks for fixing this Magnus, LGTM!
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480675484783340, "parent_rev":
"ea61f6814f4d1d03932d264bfd10f2a6df8dff37", "commit_rev":
"169f51019cf43146bc8d12efac71f4a74849c59f"}
Message was sent while issue was closed.
Description was changed from ========== VP8DecoderImpl: Fix uninitialized memory crash It is not safe to call vpx_codec_destroy if vpx_codec_dec_init failed, because the |decoder_| memory will be uninitialized. See the bug for more info. BUG=chromium:663293 ========== to ========== VP8DecoderImpl: Fix uninitialized memory crash It is not safe to call vpx_codec_destroy if vpx_codec_dec_init failed, because the |decoder_| memory will be uninitialized. See the bug for more info. BUG=chromium:663293 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== VP8DecoderImpl: Fix uninitialized memory crash It is not safe to call vpx_codec_destroy if vpx_codec_dec_init failed, because the |decoder_| memory will be uninitialized. See the bug for more info. BUG=chromium:663293 ========== to ========== VP8DecoderImpl: Fix uninitialized memory crash It is not safe to call vpx_codec_destroy if vpx_codec_dec_init failed, because the |decoder_| memory will be uninitialized. See the bug for more info. BUG=chromium:663293 Committed: https://crrev.com/5c71166dffb49510092bf87f271b6ea590acd1f1 Cr-Commit-Position: refs/heads/master@{#15381} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5c71166dffb49510092bf87f271b6ea590acd1f1 Cr-Commit-Position: refs/heads/master@{#15381} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
