Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3158)

Issue 2541053002: Allow custom drawers to be added to framelisteners. (Closed)

Created:
4 years ago by sakal
Modified:
4 years ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Allow custom drawers to be added to framelisteners. BUG=webrtc:6470 Committed: https://crrev.com/3a9bc1790ace3b7c49ede0c7067575036a65130c Cr-Commit-Position: refs/heads/master@{#15342}

Patch Set 1 #

Patch Set 2 : Copy javadoc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -18 lines) Patch
M webrtc/api/android/java/src/org/webrtc/EglRenderer.java View 9 chunks +40 lines, -18 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/SurfaceViewRenderer.java View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sakal
PTAL
4 years ago (2016-11-30 15:07:10 UTC) #3
magjed_webrtc
lgtm
4 years ago (2016-11-30 15:51:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2541053002/20001
4 years ago (2016-11-30 16:05:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 16:30:08 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-30 16:30:16 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3a9bc1790ace3b7c49ede0c7067575036a65130c
Cr-Commit-Position: refs/heads/master@{#15342}

Powered by Google App Engine
This is Rietveld 408576698