Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2541003002: Make sure GetLastError on a PlatformThread return an error that is relevant to the thread. (Closed)

Created:
4 years ago by perkj_webrtc
Modified:
4 years ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make sure GetLastError on a PlatformThread return an error that is relevant to the thread. BUG=none Committed: https://crrev.com/6a2e20ad14ac2fa09ddd5a81a8324de57bbf680b Cr-Commit-Position: refs/heads/master@{#15328}

Patch Set 1 #

Patch Set 2 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M webrtc/base/platform_thread.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tommi
lgtm. If you can add a little bit of documentation for why we do this, ...
4 years ago (2016-11-30 09:39:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2541003002/20001
4 years ago (2016-11-30 12:28:37 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 12:53:12 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-30 12:53:17 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6a2e20ad14ac2fa09ddd5a81a8324de57bbf680b
Cr-Commit-Position: refs/heads/master@{#15328}

Powered by Google App Engine
This is Rietveld 408576698