Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: webrtc/test/BUILD.gn

Issue 2540693002: Replace test_support_main by test_main and get rid of test_support_main_threaded_mac (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/test/BUILD.gn
diff --git a/webrtc/test/BUILD.gn b/webrtc/test/BUILD.gn
index c6f2f4d2e6e0e9651d32017ad72fdadaf68afa74..086543749805676de41136c92cc13ed8fbf4331c 100644
--- a/webrtc/test/BUILD.gn
+++ b/webrtc/test/BUILD.gn
@@ -22,9 +22,9 @@ group("test") {
":field_trial",
":rtp_test_utils",
":test_common",
+ ":test_main",
":test_renderer",
":test_support",
- ":test_support_main",
":test_support_unittests",
":video_test_common",
]
@@ -163,34 +163,13 @@ rtc_source_set("test_support") {
}
}
-# Depend on this target when you want to have test_support but also the
-# main method needed for gtest to execute!
-rtc_source_set("test_support_main") {
- testonly = true
-
- sources = [
- "run_all_unittests.cc",
- "test_suite.cc",
- "test_suite.h",
- ]
-
- deps = [
- ":field_trial",
- ":test_support",
- "../system_wrappers:metrics_default",
- "//testing/gmock",
- "//testing/gtest",
- "//third_party/gflags",
- ]
-}
-
# Depend on this target when you want to have test_support and a special
# main for mac which will run your test on a worker thread and consume
# events on the main thread. Useful if you want to access a webcam.
# This main will provide all the scaffolding and objective-c black magic
# for you. All you need to do is to implement a function in the
# run_threaded_main_mac.h file (ImplementThisToRunYourTest).
-rtc_source_set("test_support_main_threaded_mac") {
+rtc_source_set("test_main_threaded_mac") {
testonly = true
sources = [
@@ -276,7 +255,7 @@ rtc_test("test_support_unittests") {
deps += [
":test_common",
- ":test_support_main",
+ ":test_main",
"../modules/video_capture",
"//testing/gmock",
"//testing/gtest",

Powered by Google App Engine
This is Rietveld 408576698