Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2540633002: Cleanup unused rules in webrtc/DEPS + add kjellander to OWNERS for it (Closed)

Created:
4 years ago by kjellander_webrtc
Modified:
4 years ago
Reviewers:
the sun, henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Cleanup unused rules in webrtc/DEPS + add kjellander to OWNERS for it Remove entries for headers that no longer exists in the webrtc/ dir. BUG=webrtc:5878 NOTRY=True Committed: https://crrev.com/f17cae24f408b9f11eea6e2d17479b0985597afc Cr-Commit-Position: refs/heads/master@{#15292}

Patch Set 1 #

Patch Set 2 : Add kjellander@webrtc.org to DEPS OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M webrtc/DEPS View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
kjellander_webrtc
4 years ago (2016-11-29 08:00:30 UTC) #2
the sun
lgtm
4 years ago (2016-11-29 10:11:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2540633002/1
4 years ago (2016-11-29 10:17:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10755)
4 years ago (2016-11-29 10:20:03 UTC) #7
kjellander_webrtc
+henrika for rubberstamp and the OWNERS addition.
4 years ago (2016-11-29 10:25:11 UTC) #10
henrika_webrtc
LGTM
4 years ago (2016-11-29 10:44:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2540633002/20001
4 years ago (2016-11-29 10:51:00 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 10:52:16 UTC) #17
commit-bot: I haz the power
4 years ago (2016-11-29 10:52:29 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f17cae24f408b9f11eea6e2d17479b0985597afc
Cr-Commit-Position: refs/heads/master@{#15292}

Powered by Google App Engine
This is Rietveld 408576698