Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2540113002: Revert of Adding memcheck suppression. (Closed)

Created:
4 years ago by philipel
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Adding memcheck suppression. (patchset #1 id:1 of https://codereview.webrtc.org/2537563003/ ) Reason for revert: A fix for the related bug has landed: https://codereview.webrtc.org/2535203002 Original issue's description: > Adding memcheck suppression. > > See linked bug. > > BUG=webrtc:6788 > TBR=kjellander@webrtc.org > NOTRY=True > > Committed: https://crrev.com/bdd6f4c33288e9f7bcafa26f3a4ec8422131cb0b > Cr-Commit-Position: refs/heads/master@{#15283} TBR=kjellander@webrtc.org,deadbeef@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6788 Committed: https://crrev.com/b7e1dd7f474cfa4fc97ed81281c103b001fe54c3 Cr-Commit-Position: refs/heads/master@{#15319}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M tools/valgrind-webrtc/memcheck/suppressions.txt View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
philipel
Created Revert of Adding memcheck suppression.
4 years ago (2016-11-30 09:42:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2540113002/1
4 years ago (2016-11-30 09:43:01 UTC) #3
kjellander_webrtc
I'd suggest running the linux_memcheck bot and only submit if that goes green (and skip ...
4 years ago (2016-11-30 09:58:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2540113002/1
4 years ago (2016-11-30 10:23:53 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 10:28:10 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-30 10:28:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7e1dd7f474cfa4fc97ed81281c103b001fe54c3
Cr-Commit-Position: refs/heads/master@{#15319}

Powered by Google App Engine
This is Rietveld 408576698