Set the preferred DSCP value for Rtp data channel to be DSCP_AF41.

Set the preferred DSCP value for Rtp data channel to be DSCP_AF41.

BUG=b/31996729

Committed: https://crrev.com/ebbe4f2ed5fb1a1d065ccc4e7c9d56bb2291e8fd
Cr-Commit-Position: refs/heads/master@{#15449}

[Zhi Huang, 2016-11-30 01:41:40]

The CQ bit was checked by zhihuang@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 01:41:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-30 01:48:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 01:48:39]

Dry run: Try jobs failed on following builders:
  linux_msan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/15427)

[Taylor Brandstetter, 2016-12-01 01:51:26]

deadbeef@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[Taylor Brandstetter, 2016-12-01 01:51:27]

lgtm

[Zhi Huang, 2016-12-01 18:56:21]

The CQ bit was checked by zhihuang@webrtc.org

[commit-bot: I haz the power, 2016-12-01 18:56:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-01 19:01:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 19:01:57]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10971)

[Zhi Huang, 2016-12-01 20:16:53]

zhihuang@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[Zhi Huang, 2016-12-01 20:16:53]

Hi Peter,

Please take a look. This simple change needs the approval of /base/ directory.
Thanks.

[pthatcher1, 2016-12-01 22:18:57]

On 2016/12/01 20:16:53, Zhi Huang wrote:
> Hi Peter,
> 
> Please take a look. This simple change needs the approval of /base/ directory.
> Thanks.

lgtm

Before you submit, can you patch this into Chrome and join a Hangout and fire up
Wireshark and verify the DSCP marking values?

[Zhi Huang, 2016-12-02 02:57:48]

On 2016/12/01 22:18:57, pthatcher1 wrote:
> On 2016/12/01 20:16:53, Zhi Huang wrote:
> > Hi Peter,
> > 
> > Please take a look. This simple change needs the approval of /base/
directory.
> > Thanks.
> 
> lgtm
> 
> Before you submit, can you patch this into Chrome and join a Hangout and fire
up
> Wireshark and verify the DSCP marking values?

I tested this with hangouts video call and apprtc calls. It seems that the
datachannel's DSCP is not enabled by default.  It will set the default one which
is 0 for the socket even though the preferred one is AF41.
The DSCP will be correctly set when the DSCP is specifically enabled for data
channel.
Is this the expected behavior?

[pthatcher1, 2016-12-02 18:39:12]

On 2016/12/02 02:57:48, Zhi Huang wrote:
> On 2016/12/01 22:18:57, pthatcher1 wrote:
> > On 2016/12/01 20:16:53, Zhi Huang wrote:
> > > Hi Peter,
> > > 
> > > Please take a look. This simple change needs the approval of /base/
> directory.
> > > Thanks.
> > 
> > lgtm
> > 
> > Before you submit, can you patch this into Chrome and join a Hangout and
fire
> up
> > Wireshark and verify the DSCP marking values?
> 
> I tested this with hangouts video call and apprtc calls. It seems that the
> datachannel's DSCP is not enabled by default.  It will set the default one
which
> is 0 for the socket even though the preferred one is AF41.
> The DSCP will be correctly set when the DSCP is specifically enabled for data
> channel.
> Is this the expected behavior?

Do you mean the googDscp PeerConnection option?  If that's not on, you can just
change the default to be on in your custom build.  Or did you mean some other
control?

[Zhi Huang, 2016-12-05 19:38:41]

Hi,
I made some new changes on this CL. Please take another look.
Thanks.

[Zhi Huang, 2016-12-05 21:29:51]

The CQ bit was checked by zhihuang@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 21:29:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-05 21:35:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 21:35:36]

Dry run: Try jobs failed on following builders:
  ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/13138)
  linux_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/20946)
  linux_tsan2 on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/17701)

[pthatcher1, 2016-12-06 00:06:01]

lgtm, with a nit

https://codereview.webrtc.org/2539813003/diff/20001/webrtc/api/webrtcsession.cc
File webrtc/api/webrtcsession.cc (right):

https://codereview.webrtc.org/2539813003/diff/20001/webrtc/api/webrtcsession....
webrtc/api/webrtcsession.cc:1723: create_rtcp_transport_channel,
data_channel_type_, media_controller_));
This should be after transport_controller_.get() but before content->name.

[Zhi Huang, 2016-12-06 01:55:59]

The CQ bit was checked by zhihuang@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 01:56:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-06 02:24:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 02:24:58]

Dry run: This issue passed the CQ dry run.

[Zhi Huang, 2016-12-06 18:40:31]

The CQ bit was checked by zhihuang@webrtc.org

[Zhi Huang, 2016-12-06 18:40:32]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2539813003/#ps40001 (title:
"Remove the default parameter.")

[commit-bot: I haz the power, 2016-12-06 18:40:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-06 18:45:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481049631541680,
"parent_rev": "2f57e8e2cd9072fed19ee07f3698991b2c9f5306", "commit_rev":
"8c6cc799940b6f3cb977ed58e6f86ceb54557a4a"}

[commit-bot: I haz the power, 2016-12-06 18:45:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-06 18:45:51]

Description was changed from

==========
Set the preferred DSCP value for Rtp data channel to be DSCP_AF41.

BUG=b/31996729
==========

to

==========
Set the preferred DSCP value for Rtp data channel to be DSCP_AF41.

BUG=b/31996729

Committed: https://crrev.com/ebbe4f2ed5fb1a1d065ccc4e7c9d56bb2291e8fd
Cr-Commit-Position: refs/heads/master@{#15449}
==========

[commit-bot: I haz the power, 2016-12-06 18:45:52]

Patchset 3 (id:??) landed as
https://crrev.com/ebbe4f2ed5fb1a1d065ccc4e7c9d56bb2291e8fd
Cr-Commit-Position: refs/heads/master@{#15449}