Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2538783002: Adding RTCStatsIntegrationTest to memcheck supressions. (Closed)

Created:
4 years ago by Taylor Brandstetter
Modified:
4 years ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding RTCStatsIntegrationTest to memcheck supressions. It's at the same level as the other end-to-end tests that are also disabled. It seems to be failing because it's not fast enough to keep up with processing fake video frames. BUG=webrtc:4387 TBR=kjellander@webrtc.org NOTRY=True Committed: https://crrev.com/c4dc4a5956d03d46b5d73d91bcacd53a2fc3a417 Cr-Commit-Position: refs/heads/master@{#15302}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/valgrind-webrtc/gtest_exclude/peerconnection_unittests.gtest-memcheck.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Taylor Brandstetter
4 years ago (2016-11-29 17:01:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2538783002/1
4 years ago (2016-11-29 17:02:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 17:06:16 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c4dc4a5956d03d46b5d73d91bcacd53a2fc3a417 Cr-Commit-Position: refs/heads/master@{#15302}
4 years ago (2016-11-29 17:06:26 UTC) #10
kjellander_webrtc
4 years ago (2016-11-29 19:28:35 UTC) #11
Message was sent while issue was closed.
Lgtm
Suppressions are really the silencing of errors for tests that actually run.
This CL excludes/disables the tests from running.

Powered by Google App Engine
This is Rietveld 408576698