Description was changed from ========== Revert "Revert of Renaming AudioEncoder::SetTargetBitrate and SetProjectedPacketLossRate. (patchset #5 id:240001 ...
Description was changed from
==========
Revert "Revert of Renaming AudioEncoder::SetTargetBitrate and
SetProjectedPacketLossRate. (patchset #5 id:240001 of
https://codereview.webrtc.org/2411613002/ )"
This reverts commit e69b46863a2876dc22b45f78e8a1c0b956b6f2fd.
BUG=
==========
to
==========
Reland "Renaming AudioEncoder::SetTargetBitrate and SetProjectedPacketLossRate."
The earlier attempt of this was in
https://codereview.webrtc.org/2411613002/
It was reverted due to failures on internal bots, showing that we cannot
deprecate one method.
BUG=
==========
Description was changed from ========== Reland "Renaming AudioEncoder::SetTargetBitrate and SetProjectedPacketLossRate." The earlier attempt of this ...
Description was changed from
==========
Reland "Renaming AudioEncoder::SetTargetBitrate and SetProjectedPacketLossRate."
The earlier attempt of this was in
https://codereview.webrtc.org/2411613002/
It was reverted due to failures on internal bots, showing that we cannot
deprecate one method.
BUG=
==========
to
==========
Reland "Renaming AudioEncoder::SetTargetBitrate and SetProjectedPacketLossRate."
The earlier attempt of this was in
https://codereview.webrtc.org/2411613002/
It was reverted due to failures on internal bots, showing that we cannot
deprecate one method.
BUG=webrtc:6303
==========
minyue-webrtc
Hi Karl and Henrik Please help review this relanding, thanks!
On 2016/11/30 12:02:17, minyue-webrtc wrote:
> Hi Karl and Henrik
>
> Please help review this relanding, thanks!
lgtm, provided that patch set #1 is the original CL without changes
minyue-webrtc
On 2016/11/30 12:44:26, kwiberg-webrtc wrote: > On 2016/11/30 12:02:17, minyue-webrtc wrote: > > Hi Karl ...
On 2016/11/30 12:44:26, kwiberg-webrtc wrote:
> On 2016/11/30 12:02:17, minyue-webrtc wrote:
> > Hi Karl and Henrik
> >
> > Please help review this relanding, thanks!
>
> lgtm, provided that patch set #1 is the original CL without changes
Yes, I forgot to say it. My apologies.
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480516117325680,
"parent_rev": "e8805c8be14155b752bbbbccb131eb836df2b1de", "commit_rev":
"38a16e6073eebf325e3158be6dcb0d7a7da5f662"}
commit-bot: I haz the power
Description was changed from ========== Reland "Renaming AudioEncoder::SetTargetBitrate and SetProjectedPacketLossRate." The earlier attempt of this ...
Description was changed from
==========
Reland "Renaming AudioEncoder::SetTargetBitrate and SetProjectedPacketLossRate."
The earlier attempt of this was in
https://codereview.webrtc.org/2411613002/
It was reverted due to failures on internal bots, showing that we cannot
deprecate one method.
BUG=webrtc:6303
==========
to
==========
Reland "Renaming AudioEncoder::SetTargetBitrate and SetProjectedPacketLossRate."
The earlier attempt of this was in
https://codereview.webrtc.org/2411613002/
It was reverted due to failures on internal bots, showing that we cannot
deprecate one method.
BUG=webrtc:6303
==========
Description was changed from ========== Reland "Renaming AudioEncoder::SetTargetBitrate and SetProjectedPacketLossRate." The earlier attempt of this ...
Description was changed from
==========
Reland "Renaming AudioEncoder::SetTargetBitrate and SetProjectedPacketLossRate."
The earlier attempt of this was in
https://codereview.webrtc.org/2411613002/
It was reverted due to failures on internal bots, showing that we cannot
deprecate one method.
BUG=webrtc:6303
==========
to
==========
Reland "Renaming AudioEncoder::SetTargetBitrate and SetProjectedPacketLossRate."
The earlier attempt of this was in
https://codereview.webrtc.org/2411613002/
It was reverted due to failures on internal bots, showing that we cannot
deprecate one method.
BUG=webrtc:6303
Committed: https://crrev.com/4b9a2cb0d821aa661d96ddc002ca586ae1d3b1e6
Cr-Commit-Position: refs/heads/master@{#15333}
==========
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4b9a2cb0d821aa661d96ddc002ca586ae1d3b1e6 Cr-Commit-Position: refs/heads/master@{#15333}
Issue 2538493006: Reland "Renaming AudioEncoder::SetTargetBitrate and SetProjectedPacketLossRate."
(Closed)
Created 4 years ago by minyue-webrtc
Modified 4 years ago
Reviewers: kwiberg-webrtc, hlundin-webrtc
Base URL:
Comments: 0