Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2538493006: Reland "Renaming AudioEncoder::SetTargetBitrate and SetProjectedPacketLossRate." (Closed)

Created:
4 years ago by minyue-webrtc
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland "Renaming AudioEncoder::SetTargetBitrate and SetProjectedPacketLossRate." The earlier attempt of this was in https://codereview.webrtc.org/2411613002/ It was reverted due to failures on internal bots, showing that we cannot deprecate one method. BUG=webrtc:6303 Committed: https://crrev.com/4b9a2cb0d821aa661d96ddc002ca586ae1d3b1e6 Cr-Commit-Position: refs/heads/master@{#15333}

Patch Set 1 #

Patch Set 2 : fixing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -130 lines) Patch
M webrtc/modules/audio_coding/acm2/audio_coding_module.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_encoder.h View 1 2 chunks +4 lines, -7 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_encoder.cc View 1 2 chunks +2 lines, -8 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.h View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.h View 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h View 1 3 chunks +8 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc View 4 chunks +35 lines, -35 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus_unittest.cc View 5 chunks +42 lines, -34 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.h View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
minyue-webrtc
Hi Karl and Henrik Please help review this relanding, thanks!
4 years ago (2016-11-30 12:02:17 UTC) #4
kwiberg-webrtc
On 2016/11/30 12:02:17, minyue-webrtc wrote: > Hi Karl and Henrik > > Please help review ...
4 years ago (2016-11-30 12:44:26 UTC) #5
minyue-webrtc
On 2016/11/30 12:44:26, kwiberg-webrtc wrote: > On 2016/11/30 12:02:17, minyue-webrtc wrote: > > Hi Karl ...
4 years ago (2016-11-30 12:48:11 UTC) #6
hlundin-webrtc
lgtm
4 years ago (2016-11-30 14:27:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2538493006/20001
4 years ago (2016-11-30 14:28:40 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 14:50:04 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-30 14:50:13 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4b9a2cb0d821aa661d96ddc002ca586ae1d3b1e6
Cr-Commit-Position: refs/heads/master@{#15333}

Powered by Google App Engine
This is Rietveld 408576698