Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2538133002: Delete nalu parser in mediaencoder (Closed)

Created:
4 years ago by kthelgason
Modified:
4 years ago
Reviewers:
magjed_webrtc, sakal
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete nalu parser in mediaencoder We already have an implementation in h264_common. We should have as few of these as possible as they are subtly hard to get right and it creates work to maintain N implementations. BUG=webrtc:6546 Committed: https://crrev.com/127387e5ce2d77ed2f71fae43818c0540eb06930 Cr-Commit-Position: refs/heads/master@{#15336}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -59 lines) Patch
M webrtc/api/android/jni/androidmediaencoder_jni.cc View 6 chunks +8 lines, -59 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kthelgason
4 years ago (2016-11-30 13:42:02 UTC) #2
sakal
lgtm
4 years ago (2016-11-30 14:04:02 UTC) #3
magjed_webrtc
lgtm
4 years ago (2016-11-30 14:23:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2538133002/1
4 years ago (2016-11-30 14:23:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 15:12:51 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-30 15:12:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/127387e5ce2d77ed2f71fae43818c0540eb06930
Cr-Commit-Position: refs/heads/master@{#15336}

Powered by Google App Engine
This is Rietveld 408576698