Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: webrtc/api/rtcstatscollector_unittest.cc

Issue 2537343003: Removing "crypto_required" from MediaContentDescription. (Closed)
Patch Set: Responding to comments (mostly just renaming) Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/rtpsenderreceiver_unittest.cc » ('j') | webrtc/api/statscollector_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/rtcstatscollector_unittest.cc
diff --git a/webrtc/api/rtcstatscollector_unittest.cc b/webrtc/api/rtcstatscollector_unittest.cc
index e4c311836776be9b633a0ef663901cc6110e2d20..cf275fe00ef59d36186972c0c1c42df79be893c3 100644
--- a/webrtc/api/rtcstatscollector_unittest.cc
+++ b/webrtc/api/rtcstatscollector_unittest.cc
@@ -101,6 +101,8 @@ void PrintTo(const RTCTransportStats& stats, ::std::ostream* os) {
namespace {
const int64_t kGetStatsReportTimeoutMs = 1000;
+const bool kDefaultRtcpEnabled = false;
+const bool kDefaultSecureRequired = true;
pthatcher1 2016/12/01 22:57:12 kDefaultSrtpRequired?
Taylor Brandstetter 2016/12/02 00:42:32 Done.
struct CertificateInfo {
rtc::scoped_refptr<rtc::RTCCertificate> certificate;
@@ -785,12 +787,13 @@ TEST_F(RTCStatsCollectorTest, CollectRTCCodecStats) {
MockVoiceMediaChannel* voice_media_channel = new MockVoiceMediaChannel();
cricket::VoiceChannel voice_channel(
test_->worker_thread(), test_->network_thread(), test_->media_engine(),
- voice_media_channel, nullptr, "VoiceContentName", false);
+ voice_media_channel, nullptr, "VoiceContentName", kDefaultRtcpEnabled,
+ kDefaultSecureRequired);
MockVideoMediaChannel* video_media_channel = new MockVideoMediaChannel();
cricket::VideoChannel video_channel(
test_->worker_thread(), test_->network_thread(), video_media_channel,
- nullptr, "VideoContentName", false);
+ nullptr, "VideoContentName", kDefaultRtcpEnabled, kDefaultSecureRequired);
// Audio
cricket::VoiceMediaInfo voice_media_info;
@@ -1403,7 +1406,8 @@ TEST_F(RTCStatsCollectorTest, CollectRTCInboundRTPStreamStats_Audio) {
MockVoiceMediaChannel* voice_media_channel = new MockVoiceMediaChannel();
cricket::VoiceChannel voice_channel(
test_->worker_thread(), test_->network_thread(), test_->media_engine(),
- voice_media_channel, nullptr, "VoiceContentName", false);
+ voice_media_channel, nullptr, "VoiceContentName", kDefaultRtcpEnabled,
+ kDefaultSecureRequired);
cricket::VoiceMediaInfo voice_media_info;
@@ -1471,7 +1475,7 @@ TEST_F(RTCStatsCollectorTest, CollectRTCInboundRTPStreamStats_Video) {
MockVideoMediaChannel* video_media_channel = new MockVideoMediaChannel();
cricket::VideoChannel video_channel(
test_->worker_thread(), test_->network_thread(), video_media_channel,
- nullptr, "VideoContentName", false);
+ nullptr, "VideoContentName", kDefaultRtcpEnabled, kDefaultSecureRequired);
cricket::VideoMediaInfo video_media_info;
@@ -1543,7 +1547,8 @@ TEST_F(RTCStatsCollectorTest, CollectRTCOutboundRTPStreamStats_Audio) {
MockVoiceMediaChannel* voice_media_channel = new MockVoiceMediaChannel();
cricket::VoiceChannel voice_channel(
test_->worker_thread(), test_->network_thread(), test_->media_engine(),
- voice_media_channel, nullptr, "VoiceContentName", false);
+ voice_media_channel, nullptr, "VoiceContentName", kDefaultRtcpEnabled,
+ kDefaultSecureRequired);
cricket::VoiceMediaInfo voice_media_info;
@@ -1608,7 +1613,7 @@ TEST_F(RTCStatsCollectorTest, CollectRTCOutboundRTPStreamStats_Video) {
MockVideoMediaChannel* video_media_channel = new MockVideoMediaChannel();
cricket::VideoChannel video_channel(
test_->worker_thread(), test_->network_thread(), video_media_channel,
- nullptr, "VideoContentName", false);
+ nullptr, "VideoContentName", kDefaultRtcpEnabled, kDefaultSecureRequired);
cricket::VideoMediaInfo video_media_info;
« no previous file with comments | « no previous file | webrtc/api/rtpsenderreceiver_unittest.cc » ('j') | webrtc/api/statscollector_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698