Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: webrtc/pc/channel.cc

Issue 2537343003: Removing "crypto_required" from MediaContentDescription. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/pc/channel.cc
diff --git a/webrtc/pc/channel.cc b/webrtc/pc/channel.cc
index f3c3211fdfbf2d5f5f42ba52f4dd2f26c81d72da..020c444f2d09d0659f05868015812e700ee244ba 100644
--- a/webrtc/pc/channel.cc
+++ b/webrtc/pc/channel.cc
@@ -164,7 +164,8 @@ BaseChannel::BaseChannel(rtc::Thread* worker_thread,
MediaChannel* media_channel,
TransportController* transport_controller,
const std::string& content_name,
- bool rtcp)
+ bool rtcp,
+ bool secure_required)
: worker_thread_(worker_thread),
network_thread_(network_thread),
@@ -172,6 +173,7 @@ BaseChannel::BaseChannel(rtc::Thread* worker_thread,
transport_controller_(transport_controller),
rtcp_enabled_(rtcp),
+ secure_required_(secure_required),
media_channel_(media_channel),
selected_candidate_pair_(nullptr) {
RTC_DCHECK(worker_thread_ == rtc::Thread::Current());
@@ -1098,10 +1100,6 @@ bool BaseChannel::SetRtpTransportParameters_n(
std::string* error_desc) {
RTC_DCHECK(network_thread_->IsCurrent());
- if (src == CS_LOCAL) {
- set_secure_required(content->crypto_required() != CT_NONE);
- }
-
if (!SetSrtp_n(content->cryptos(), action, src, error_desc)) {
return false;
}
@@ -1470,13 +1468,15 @@ VoiceChannel::VoiceChannel(rtc::Thread* worker_thread,
VoiceMediaChannel* media_channel,
TransportController* transport_controller,
const std::string& content_name,
- bool rtcp)
+ bool rtcp,
+ bool secure_required)
: BaseChannel(worker_thread,
network_thread,
media_channel,
transport_controller,
content_name,
- rtcp),
+ rtcp,
+ secure_required),
media_engine_(media_engine),
received_media_(false) {}
@@ -1883,13 +1883,15 @@ VideoChannel::VideoChannel(rtc::Thread* worker_thread,
VideoMediaChannel* media_channel,
TransportController* transport_controller,
const std::string& content_name,
- bool rtcp)
+ bool rtcp,
+ bool secure_required)
: BaseChannel(worker_thread,
network_thread,
media_channel,
transport_controller,
content_name,
- rtcp) {}
+ rtcp,
+ secure_required) {}
bool VideoChannel::Init_w(const std::string* bundle_transport_name) {
if (!BaseChannel::Init_w(bundle_transport_name)) {
@@ -2144,13 +2146,15 @@ DataChannel::DataChannel(rtc::Thread* worker_thread,
DataMediaChannel* media_channel,
TransportController* transport_controller,
const std::string& content_name,
- bool rtcp)
+ bool rtcp,
+ bool secure_required)
: BaseChannel(worker_thread,
network_thread,
media_channel,
transport_controller,
content_name,
- rtcp),
+ rtcp,
+ secure_required),
data_channel_type_(cricket::DCT_NONE),
ready_to_send_data_(false) {}

Powered by Google App Engine
This is Rietveld 408576698