Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years ago by kthelgason Modified:
4 years ago Reviewers:
magjed_webrtc, tkchin_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRemove warning suppression from VideoToolboxEncoder
This warning no longer needs to be supressed as the issue
has been fixed.
BUG=webrtc:6307
TBR=tkchin@webrtc.org
Committed: https://crrev.com/18f7c8d4dfba28c8b51fb6a104c2dabbadad56ed
Cr-Commit-Position: refs/heads/master@{#15331}
Patch Set 1 #
Created: 4 years ago
Messages
Total messages: 14 (7 generated)
kthelgason@webrtc.org changed reviewers: + magjed@webrtc.org
kthelgason@webrtc.org changed reviewers: + tkchin@webrtc.org
Adding Zeke as reviewer also. This should be a trivial review.
lgtm
Description was changed from ========== Remove warning suppression from VideoToolboxEncoder This warning no longer needs to be supressed as the issue has been fixed. BUG=webrtc:6307 ========== to ========== Remove warning suppression from VideoToolboxEncoder This warning no longer needs to be supressed as the issue has been fixed. BUG=webrtc:6307 TBR=tkchin@webrtc.org ==========
The CQ bit was checked by kthelgason@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480510840823450, "parent_rev":
"017b48987b3627264872f30e7da1dfb174f3b2be", "commit_rev":
"da883992eef935f9c4772e84fbeee430b2e8d401"}
Message was sent while issue was closed.
Description was changed from ========== Remove warning suppression from VideoToolboxEncoder This warning no longer needs to be supressed as the issue has been fixed. BUG=webrtc:6307 TBR=tkchin@webrtc.org ========== to ========== Remove warning suppression from VideoToolboxEncoder This warning no longer needs to be supressed as the issue has been fixed. BUG=webrtc:6307 TBR=tkchin@webrtc.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove warning suppression from VideoToolboxEncoder This warning no longer needs to be supressed as the issue has been fixed. BUG=webrtc:6307 TBR=tkchin@webrtc.org ========== to ========== Remove warning suppression from VideoToolboxEncoder This warning no longer needs to be supressed as the issue has been fixed. BUG=webrtc:6307 TBR=tkchin@webrtc.org Committed: https://crrev.com/18f7c8d4dfba28c8b51fb6a104c2dabbadad56ed Cr-Commit-Position: refs/heads/master@{#15331} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/18f7c8d4dfba28c8b51fb6a104c2dabbadad56ed Cr-Commit-Position: refs/heads/master@{#15331}
Message was sent while issue was closed.
On 2016/11/30 13:31:12, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as > https://crrev.com/18f7c8d4dfba28c8b51fb6a104c2dabbadad56ed > Cr-Commit-Position: refs/heads/master@{#15331} lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
