Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2537293003: Remove warning suppression from VideoToolboxEncoder (Closed)

Created:
4 years ago by kthelgason
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove warning suppression from VideoToolboxEncoder This warning no longer needs to be supressed as the issue has been fixed. BUG=webrtc:6307 TBR=tkchin@webrtc.org Committed: https://crrev.com/18f7c8d4dfba28c8b51fb6a104c2dabbadad56ed Cr-Commit-Position: refs/heads/master@{#15331}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M webrtc/sdk/BUILD.gn View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
kthelgason
4 years ago (2016-11-30 12:49:45 UTC) #2
kthelgason
Adding Zeke as reviewer also. This should be a trivial review.
4 years ago (2016-11-30 12:50:19 UTC) #4
magjed_webrtc
lgtm
4 years ago (2016-11-30 12:51:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2537293003/1
4 years ago (2016-11-30 13:00:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 13:31:04 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/18f7c8d4dfba28c8b51fb6a104c2dabbadad56ed Cr-Commit-Position: refs/heads/master@{#15331}
4 years ago (2016-11-30 13:31:12 UTC) #13
tkchin_webrtc
4 years ago (2016-11-30 18:38:59 UTC) #14
Message was sent while issue was closed.
On 2016/11/30 13:31:12, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/18f7c8d4dfba28c8b51fb6a104c2dabbadad56ed
> Cr-Commit-Position: refs/heads/master@{#15331}

lgtm

Powered by Google App Engine
This is Rietveld 408576698