Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 2537243004: Revert of Renaming AudioEncoder::SetTargetBitrate and SetProjectedPacketLossRate. (Closed)

Created:
4 years ago by minyue-webrtc
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Renaming AudioEncoder::SetTargetBitrate and SetProjectedPacketLossRate. (patchset #5 id:240001 of https://codereview.webrtc.org/2411613002/ ) Reason for revert: internal bot failure Original issue's description: > Renaming AudioEncoder::SetTargetBitrate and SetProjectedPacketLossRate. > > BUG=webrtc:6303 > > Committed: https://crrev.com/84e56d576806635c966093d5421c5d04c9b90746 > Cr-Commit-Position: refs/heads/master@{#15310} TBR=kwiberg@webrtc.org,henrik.lundin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6303 Committed: https://crrev.com/e69b46863a2876dc22b45f78e8a1c0b956b6f2fd Cr-Commit-Position: refs/heads/master@{#15312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -137 lines) Patch
M webrtc/modules/audio_coding/acm2/audio_coding_module.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_encoder.h View 2 chunks +11 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_encoder.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.h View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc View 1 chunk +8 lines, -11 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.h View 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h View 3 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc View 4 chunks +35 lines, -35 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus_unittest.cc View 5 chunks +34 lines, -42 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.h View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.cc View 1 chunk +8 lines, -11 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
minyue-webrtc
Created Revert of Renaming AudioEncoder::SetTargetBitrate and SetProjectedPacketLossRate.
4 years ago (2016-11-30 09:18:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2537243004/1
4 years ago (2016-11-30 09:18:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 09:19:03 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e69b46863a2876dc22b45f78e8a1c0b956b6f2fd Cr-Commit-Position: refs/heads/master@{#15312}
4 years ago (2016-11-30 09:19:09 UTC) #7
hlundin-webrtc
4 years ago (2016-11-30 09:42:34 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698