Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Issue 2536753002: Relanding "Pass time constant to bwe smoothing filter." (Closed)

Created:
4 years ago by minyue-webrtc
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), Andrew MacDonald, zhengzhonghou_agora.io, henrika_webrtc, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, the sun, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Relanding "Pass time constant to bwe smoothing filter." An earlier attempt to land this was in https://codereview.webrtc.org/2518923003/ It was failed because it removed an API. This CL fixes this. BUG=webrtc:6443, webrtc:6303 Committed: https://crrev.com/78b4d56535bd7343d00f1b3fc6f68e7446341a1d Cr-Commit-Position: refs/heads/master@{#15325}

Patch Set 1 #

Patch Set 2 : fixing #

Patch Set 3 : suppressing overloaded-virtual #

Patch Set 4 : rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -128 lines) Patch
M webrtc/audio/audio_send_stream.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/audio/audio_send_stream.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 1 2 3 2 chunks +24 lines, -0 lines 0 comments Download
M webrtc/call/bitrate_allocator.h View 3 chunks +6 lines, -2 lines 0 comments Download
M webrtc/call/bitrate_allocator.cc View 1 2 3 4 chunks +9 lines, -4 lines 0 comments Download
M webrtc/call/bitrate_allocator_unittest.cc View 19 chunks +77 lines, -54 lines 0 comments Download
M webrtc/call/call.cc View 1 2 3 2 chunks +19 lines, -8 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller_unittest.cc View 1 2 3 7 chunks +28 lines, -16 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.h View 3 chunks +3 lines, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.cc View 2 chunks +6 lines, -1 line 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/include/congestion_controller.h View 1 2 3 2 chunks +10 lines, -1 line 0 comments Download
M webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h View 1 2 3 1 chunk +7 lines, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/probing_interval_estimator.h View 1 chunk +7 lines, -5 lines 0 comments Download
M webrtc/modules/congestion_controller/probing_interval_estimator.cc View 2 chunks +11 lines, -6 lines 0 comments Download
M webrtc/modules/congestion_controller/probing_interval_estimator_unittest.cc View 6 chunks +9 lines, -10 lines 0 comments Download
M webrtc/modules/congestion_controller/transport_feedback_adapter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/transport_feedback_adapter.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/test/fuzzers/congestion_controller_feedback_fuzzer.cc View 1 2 3 1 chunk +7 lines, -1 line 0 comments Download
M webrtc/test/mock_voe_channel_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.cc View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
M webrtc/video/video_send_stream.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/voice_engine/channel.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/channel.cc View 1 2 3 2 chunks +10 lines, -5 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/channel_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/voe_codec_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 30 (16 generated)
minyue-webrtc
hi Reviewers, One earlier CL of ours got reverted. This is try to reland it. ...
4 years ago (2016-11-28 21:27:10 UTC) #6
michaelt
lgtm
4 years ago (2016-11-29 08:21:11 UTC) #7
stefan-webrtc
lgtm
4 years ago (2016-11-29 09:06:04 UTC) #8
the sun
rs lgtm
4 years ago (2016-11-29 16:01:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2536753002/60001
4 years ago (2016-11-29 16:02:24 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg/builds/9331)
4 years ago (2016-11-29 16:08:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2536753002/60001
4 years ago (2016-11-30 08:24:44 UTC) #15
minyue-webrtc
I have to suppress a compiler warning. The solution follows http://stackoverflow.com/questions/888235/overriding-a-bases-overloaded-function-in-c/888313#888313 Reviewers, You may take ...
4 years ago (2016-11-30 08:44:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2536753002/80001
4 years ago (2016-11-30 11:51:03 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/20539)
4 years ago (2016-11-30 11:54:33 UTC) #21
minyue-webrtc
On 2016/11/30 11:54:33, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years ago (2016-11-30 12:11:20 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2536753002/100001
4 years ago (2016-11-30 12:25:21 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:100001)
4 years ago (2016-11-30 12:47:44 UTC) #28
commit-bot: I haz the power
4 years ago (2016-11-30 12:47:52 UTC) #30
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/78b4d56535bd7343d00f1b3fc6f68e7446341a1d
Cr-Commit-Position: refs/heads/master@{#15325}

Powered by Google App Engine
This is Rietveld 408576698