Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2536743002: Use RateCounter for input/sent fps stats. Reports average of periodically computed stats over a cal… (Closed)

Created:
4 years ago by åsapersson
Modified:
4 years ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use RateCounter for input/sent fps stats. Reports average of periodically computed stats over a call. Intervals when video is paused is no longer included in the stats: "WebRTC.Video.InputFramesPerSecond" "WebRTC.Video.SentFramesPerSecond" BUG=webrtc:5283 Committed: https://crrev.com/320e45ad8750c52458bf054b321108c9f1949622 Cr-Commit-Position: refs/heads/master@{#15285}

Patch Set 1 : moved from https://codereview.webrtc.org/2283693002/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -14 lines) Patch
M webrtc/video/send_statistics_proxy.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 5 chunks +23 lines, -6 lines 0 comments Download
M webrtc/video/send_statistics_proxy_unittest.cc View 3 chunks +106 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
åsapersson
4 years ago (2016-11-28 16:14:16 UTC) #5
stefan-webrtc
lgtm
4 years ago (2016-11-29 09:23:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2536743002/1
4 years ago (2016-11-29 09:38:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 09:40:40 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-29 09:40:51 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/320e45ad8750c52458bf054b321108c9f1949622
Cr-Commit-Position: refs/heads/master@{#15285}

Powered by Google App Engine
This is Rietveld 408576698