Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2536133002: Ignore newly added resource files. (Closed)

Created:
4 years ago by charujain
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Ignore newly added resource files. As part of https://codereview.webrtc.org/2532963002/ we added two new resource file which needs to be ignored. BUG=webrtc:6761 NOTRY=true Committed: https://crrev.com/19223ace6506ca35a95b752086a82364f76e23f2 Cr-Commit-Position: refs/heads/master@{#15290}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Re-align #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M .gitignore View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
charujain
PTAL
4 years ago (2016-11-29 10:10:04 UTC) #3
kjellander_webrtc
lgtm, don't forget NOTRY=True on this one. https://codereview.webrtc.org/2536133002/diff/1/.gitignore File .gitignore (right): https://codereview.webrtc.org/2536133002/diff/1/.gitignore#newcode69 .gitignore:69: /resources/**/*.y4m move ...
4 years ago (2016-11-29 10:18:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2536133002/20001
4 years ago (2016-11-29 10:21:23 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 10:23:01 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-29 10:23:10 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/19223ace6506ca35a95b752086a82364f76e23f2
Cr-Commit-Position: refs/heads/master@{#15290}

Powered by Google App Engine
This is Rietveld 408576698