Reduce ProbeController::kDefaultMaxProbingBitrateBps to 10 Mbps.

Reduce ProbeController::kDefaultMaxProbingBitrateBps to 10 mbps.

BUG=none

Committed: https://crrev.com/06251f1955e4b20d860541e1057ba14a6026f36f
Cr-Commit-Position: refs/heads/master@{#15322}

[philipel, 2016-11-29 16:03:47]

philipel@webrtc.org changed reviewers:
+ sergeyu@chromium.org, stefan@webrtc.org

[philipel, 2016-11-29 16:03:47]

Sergey, I reduced the default max probing rate to 5 Mbps. I don't think the
current probing mechanism works well for probing at high bitrates and, as I
mentioned earlier, it is quite noisy in its results even for 2-3 Mbps.

I am curious though, have you done any tests probing to 20, 50 or even 100 Mbps?
How well did it work?

[Sergey Ulanov, 2016-11-29 20:19:31]

Maybe change it to 10 Mbps, the way it was before my change?
Otherwise LGTM.

I do get reasonable numbers for probed BW estimate between 10Mbps and 80Mbps,
usually within 20% of the numbers I get from BW speed test on the same
connection (https://www.google.com/#q=speed+test). In tests the measured BW is
usually slightly below the actual value, but  close. For some reason probed BW
estimate is never above 80Mbps, even when both peers are on the same machine and
BW is virtually unlimited. Yes, the measurement is somewhat noisy, but it is to
be expected, particularly on wireless networks.

[philipel, 2016-11-30 10:13:39]

Description was changed from

==========
Reduce ProbeController::kDefaultMaxProbingBitrateBps to 5 mbps.

BUG=none
==========

to

==========
Reduce ProbeController::kDefaultMaxProbingBitrateBps to 10 mbps.

BUG=none
==========

[philipel, 2016-11-30 10:14:26]

Changed to 10 Mbps.

I'm surprised it works that well.

[stefan-webrtc, 2016-11-30 10:25:39]

lgtm

[philipel, 2016-11-30 10:26:35]

The CQ bit was checked by philipel@webrtc.org

[philipel, 2016-11-30 10:26:36]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.webrtc.org/2535903003/#ps20001 (title:
"kDefaultMaxProbingBitrateBps = 10000000")

[commit-bot: I haz the power, 2016-11-30 10:26:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-30 10:48:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480501595995740,
"parent_rev": "9e016dafab2a5a77406a3c740edabc7e3e9ad309", "commit_rev":
"ba173f80bb3ce09acf200c2ff8b17a9e6613552c"}

[commit-bot: I haz the power, 2016-11-30 10:48:40]

Description was changed from

==========
Reduce ProbeController::kDefaultMaxProbingBitrateBps to 10 mbps.

BUG=none
==========

to

==========
Reduce ProbeController::kDefaultMaxProbingBitrateBps to 10 mbps.

BUG=none
==========

[commit-bot: I haz the power, 2016-11-30 10:48:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-30 10:48:48]

Description was changed from

==========
Reduce ProbeController::kDefaultMaxProbingBitrateBps to 10 mbps.

BUG=none
==========

to

==========
Reduce ProbeController::kDefaultMaxProbingBitrateBps to 10 mbps.

BUG=none

Committed: https://crrev.com/06251f1955e4b20d860541e1057ba14a6026f36f
Cr-Commit-Position: refs/heads/master@{#15322}
==========

[commit-bot: I haz the power, 2016-11-30 10:48:53]

Patchset 2 (id:??) landed as
https://crrev.com/06251f1955e4b20d860541e1057ba14a6026f36f
Cr-Commit-Position: refs/heads/master@{#15322}