Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2535783002: Revert of Bug in ExtractFrame API (extracts frames incorrectly) (Closed)

Created:
4 years ago by charujain
Modified:
4 years ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kjellander (google.com)
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Bug in ExtractFrame API (extracts frames incorrectly) (patchset #9 id:130001 of https://codereview.webrtc.org/2529923002/ ) Reason for revert: Breaking some trybots due to memory error. Original issue's description: > Fixed bug in ExtractFrameFromY4mFile API which was not extracting the frames correctly. > > Issue: This API was calculating the file_header and frame_header offset only for the first frame which is not the right logic. We need to skip the file and frame header every time we extract a new frame. > > Also added a unit test case which compares the extracted frame with the frame stored in text file. > > BUG=webrtc:6761 > > NOPRESUBMIT=true > NOTRY=true > > Committed: https://crrev.com/b7636b4656d7f8c368963f2256dc2ef7b7ba89c8 > Cr-Commit-Position: refs/heads/master@{#15260} TBR=phoglund@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6761 Committed: https://crrev.com/26fa6b210337aef9689a9fb57f82491734abe8b4 Cr-Commit-Position: refs/heads/master@{#15262}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -65 lines) Patch
D resources/reference_less_video_test_file.y4m.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D resources/video_quality_analysis_frame.txt.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/tools/BUILD.gn View 1 chunk +1 line, -5 lines 0 comments Download
M webrtc/tools/frame_analyzer/video_quality_analysis.cc View 3 chunks +31 lines, -32 lines 0 comments Download
M webrtc/tools/frame_analyzer/video_quality_analysis_unittest.cc View 2 chunks +0 lines, -26 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
charujain
Created Revert of Bug in ExtractFrame API (extracts frames incorrectly)
4 years ago (2016-11-28 13:33:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2535783002/1
4 years ago (2016-11-28 13:34:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 13:34:09 UTC) #5
commit-bot: I haz the power
4 years ago (2016-11-28 13:34:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26fa6b210337aef9689a9fb57f82491734abe8b4
Cr-Commit-Position: refs/heads/master@{#15262}

Powered by Google App Engine
This is Rietveld 408576698