webrtc/modules/audio_processing/level_controller/signal_classifier.cc - Issue 2535593002: RTC_[D]CHECK_op: Remove "u" suffix on integer constants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/level_controller/signal_classifier.cc

Issue 2535593002: RTC_[D]CHECK_op: Remove "u" suffix on integer constants (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_processing/level_controller/noise_spectrum_estimator.cc ('k') | webrtc/modules/audio_processing/low_cut_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/level_controller/signal_classifier.cc

diff --git a/webrtc/modules/audio_processing/level_controller/signal_classifier.cc b/webrtc/modules/audio_processing/level_controller/signal_classifier.cc

index dd67737403aba12e9cdf089c4bef463dac53d4a5..f38dfb2e1387a2921412de3af96f96c0434f98be 100644

--- a/webrtc/modules/audio_processing/level_controller/signal_classifier.cc

+++ b/webrtc/modules/audio_processing/level_controller/signal_classifier.cc

@@ -25,7 +25,7 @@ namespace webrtc {

namespace {

void RemoveDcLevel(rtc::ArrayView<float> x) {

- RTC_DCHECK_LT(0u, x.size());

+ RTC_DCHECK_LT(0, x.size());

float mean = std::accumulate(x.data(), x.data() + x.size(), 0.f);

mean /= x.size();

@@ -37,8 +37,8 @@ void RemoveDcLevel(rtc::ArrayView<float> x) {

void PowerSpectrum(const OouraFft* ooura_fft,

rtc::ArrayView<const float> x,

rtc::ArrayView<float> spectrum) {

- RTC_DCHECK_EQ(65u, spectrum.size());

- RTC_DCHECK_EQ(128u, x.size());

+ RTC_DCHECK_EQ(65, spectrum.size());

+ RTC_DCHECK_EQ(128, x.size());

float X[128];

std::copy(x.data(), x.data() + x.size(), X);

ooura_fft->Fft(X);