webrtc/sdk/objc/Framework/Headers/WebRTC/RTCAudioSource.h - Issue 2534843002: Added support for changing the volume of RTCAudioSource as discussed in BUG=webrtc:6533

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCAudioSource.h

Issue 2534843002: Added support for changing the volume of RTCAudioSource as discussed in BUG=webrtc:6533 (Closed)

Patch Set: use @property for changing volume of RTCAudioSource Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« webrtc/sdk/objc/Framework/Classes/RTCAudioSource.mm ('K') | « webrtc/sdk/objc/Framework/Classes/RTCAudioSource.mm ('k') | no next file » | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright 2016 The WebRTC project authors. All Rights Reserved.	2 * Copyright 2016 The WebRTC project authors. All Rights Reserved.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license	4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source	5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found	6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may	7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.	8 * be found in the AUTHORS file in the root of the source tree.

9 */	9 */

10	10

11 #import <Foundation/Foundation.h>	11 #import <Foundation/Foundation.h>

12	12

13 #import <WebRTC/RTCMacros.h>	13 #import <WebRTC/RTCMacros.h>

14 #import <WebRTC/RTCMediaSource.h>	14 #import <WebRTC/RTCMediaSource.h>

15	15

16 NS_ASSUME_NONNULL_BEGIN	16 NS_ASSUME_NONNULL_BEGIN

17	17

18 RTC_EXPORT	18 RTC_EXPORT

19 @interface RTCAudioSource : RTCMediaSource	19 @interface RTCAudioSource : RTCMediaSource

20	20

21 - (instancetype)init NS_UNAVAILABLE;	21 - (instancetype)init NS_UNAVAILABLE;

22	22

	23 @property(nonatomic) double volume;
	tkchin_webrtc 2016/11/28 21:29:54 nit: nonatomic, assign doco that this is temporar nit: nonatomic, assign doco that this is temporary, link to a bug with plans for future fix doco what the valid range is, what happens if out of bounds the sun 2016/11/30 11:38:04 Currently SetVolume() is a no-op for local streams Show quoted text On 2016/11/28 21:29:54, tkchin_webrtc wrote: > nit: nonatomic, assign > > doco that this is temporary, link to a bug with plans for future fix > > doco what the valid range is, what happens if out of bounds Currently SetVolume() is a no-op for local streams. Frederik 2016/12/01 18:54:31 Done. Show quoted text On 2016/11/28 21:29:54, tkchin_webrtc wrote: > nit: nonatomic, assign > > doco that this is temporary, link to a bug with plans for future fix > > doco what the valid range is, what happens if out of bounds Done.
	24

23 @end	25 @end

24	26

25 NS_ASSUME_NONNULL_END	27 NS_ASSUME_NONNULL_END

OLD	NEW