Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Side by Side Diff: webrtc/video/video_quality_test.cc

Issue 2534683002: RTC_[D]CHECK_op: Remove superfluous casts (Closed)
Patch Set: test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« webrtc/base/safe_compare.h ('K') | « webrtc/test/rtcp_packet_parser.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include "webrtc/video/video_quality_test.h" 10 #include "webrtc/video/video_quality_test.h"
(...skipping 859 matching lines...) Expand 10 before | Expand all | Expand 10 after
870 // TODO(ivica): Should max_bitrate_bps == -1 represent inf max bitrate, as it 870 // TODO(ivica): Should max_bitrate_bps == -1 represent inf max bitrate, as it
871 // does in some parts of the code? 871 // does in some parts of the code?
872 RTC_CHECK_GE(params_.video.max_bitrate_bps, params_.video.target_bitrate_bps); 872 RTC_CHECK_GE(params_.video.max_bitrate_bps, params_.video.target_bitrate_bps);
873 RTC_CHECK_GE(params_.video.target_bitrate_bps, params_.video.min_bitrate_bps); 873 RTC_CHECK_GE(params_.video.target_bitrate_bps, params_.video.min_bitrate_bps);
874 RTC_CHECK_LT(params_.video.selected_tl, params_.video.num_temporal_layers); 874 RTC_CHECK_LT(params_.video.selected_tl, params_.video.num_temporal_layers);
875 RTC_CHECK_LT(params_.ss.selected_stream, params_.ss.streams.size()); 875 RTC_CHECK_LT(params_.ss.selected_stream, params_.ss.streams.size());
876 for (const VideoStream& stream : params_.ss.streams) { 876 for (const VideoStream& stream : params_.ss.streams) {
877 RTC_CHECK_GE(stream.min_bitrate_bps, 0); 877 RTC_CHECK_GE(stream.min_bitrate_bps, 0);
878 RTC_CHECK_GE(stream.target_bitrate_bps, stream.min_bitrate_bps); 878 RTC_CHECK_GE(stream.target_bitrate_bps, stream.min_bitrate_bps);
879 RTC_CHECK_GE(stream.max_bitrate_bps, stream.target_bitrate_bps); 879 RTC_CHECK_GE(stream.max_bitrate_bps, stream.target_bitrate_bps);
880 RTC_CHECK_EQ(static_cast<int>(stream.temporal_layer_thresholds_bps.size()), 880 RTC_CHECK_EQ(stream.temporal_layer_thresholds_bps.size(),
881 params_.video.num_temporal_layers - 1); 881 params_.video.num_temporal_layers - 1);
882 } 882 }
883 // TODO(ivica): Should we check if the sum of all streams/layers is equal to 883 // TODO(ivica): Should we check if the sum of all streams/layers is equal to
884 // the total bitrate? We anyway have to update them in the case bitrate 884 // the total bitrate? We anyway have to update them in the case bitrate
885 // estimator changes the total bitrates. 885 // estimator changes the total bitrates.
886 RTC_CHECK_GE(params_.ss.num_spatial_layers, 1); 886 RTC_CHECK_GE(params_.ss.num_spatial_layers, 1);
887 RTC_CHECK_LE(params_.ss.selected_sl, params_.ss.num_spatial_layers); 887 RTC_CHECK_LE(params_.ss.selected_sl, params_.ss.num_spatial_layers);
888 RTC_CHECK(params_.ss.spatial_layers.empty() || 888 RTC_CHECK(params_.ss.spatial_layers.empty() ||
889 params_.ss.spatial_layers.size() == 889 params_.ss.spatial_layers.size() ==
890 static_cast<size_t>(params_.ss.num_spatial_layers)); 890 static_cast<size_t>(params_.ss.num_spatial_layers));
(...skipping 594 matching lines...) Expand 10 before | Expand all | Expand 10 after
1485 std::ostringstream str; 1485 std::ostringstream str;
1486 str << receive_logs_++; 1486 str << receive_logs_++;
1487 std::string path = 1487 std::string path =
1488 params_.video.encoded_frame_base_path + "." + str.str() + ".recv.ivf"; 1488 params_.video.encoded_frame_base_path + "." + str.str() + ".recv.ivf";
1489 stream->EnableEncodedFrameRecording(rtc::CreatePlatformFile(path), 1489 stream->EnableEncodedFrameRecording(rtc::CreatePlatformFile(path),
1490 10000000); 1490 10000000);
1491 } 1491 }
1492 } 1492 }
1493 1493
1494 } // namespace webrtc 1494 } // namespace webrtc
OLDNEW
« webrtc/base/safe_compare.h ('K') | « webrtc/test/rtcp_packet_parser.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698