Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: webrtc/base/file_posix.cc

Issue 2534683002: RTC_[D]CHECK_op: Remove superfluous casts (Closed)
Patch Set: test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 offset + total_read); 74 offset + total_read);
75 } while (read == -1 && errno == EINTR); 75 } while (read == -1 && errno == EINTR);
76 if (read == -1) 76 if (read == -1)
77 break; 77 break;
78 total_read += read; 78 total_read += read;
79 } while (total_read < length); 79 } while (total_read < length);
80 return total_read; 80 return total_read;
81 } 81 }
82 82
83 bool File::Seek(size_t offset) { 83 bool File::Seek(size_t offset) {
84 RTC_DCHECK_LE(offset, static_cast<size_t>(std::numeric_limits<off_t>::max())); 84 RTC_DCHECK_LE(offset, std::numeric_limits<off_t>::max());
85 return lseek(file_, static_cast<off_t>(offset), SEEK_SET) != -1; 85 return lseek(file_, static_cast<off_t>(offset), SEEK_SET) != -1;
86 } 86 }
87 87
88 bool File::Close() { 88 bool File::Close() {
89 if (file_ == rtc::kInvalidPlatformFileValue) 89 if (file_ == rtc::kInvalidPlatformFileValue)
90 return false; 90 return false;
91 bool ret = close(file_) == 0; 91 bool ret = close(file_) == 0;
92 file_ = rtc::kInvalidPlatformFileValue; 92 file_ = rtc::kInvalidPlatformFileValue;
93 return ret; 93 return ret;
94 } 94 }
95 95
96 } // namespace rtc 96 } // namespace rtc
OLDNEW
« no previous file with comments | « webrtc/base/checks.h ('k') | webrtc/base/random_unittest.cc » ('j') | webrtc/base/safe_compare.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698