Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2534593002: Get rid of webrtc/base/latebindingsymboltable* (Closed)

Created:
4 years ago by ehmaldonado_webrtc
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Get rid of webrtc/base/latebindingsymboltable* It is blocking the chromium roll and they don't seem to be used. R=phoglund@webrtc.org, kjellander@webrtc.org, henrika@webrtc.org BUG=webrtc:6775, webrtc:6739 NOTRY=True Committed: https://crrev.com/03d6b086df1e2571fd2b36d6a989f8c51becb6bc Cr-Commit-Position: refs/heads/master@{#15246}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -445 lines) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
D webrtc/base/latebindingsymboltable.h View 1 chunk +0 lines, -70 lines 0 comments Download
D webrtc/base/latebindingsymboltable.cc View 1 chunk +0 lines, -156 lines 0 comments Download
D webrtc/base/latebindingsymboltable.cc.def View 1 chunk +0 lines, -69 lines 0 comments Download
D webrtc/base/latebindingsymboltable.h.def View 1 chunk +0 lines, -83 lines 0 comments Download
D webrtc/base/latebindingsymboltable_unittest.cc View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
ehmaldonado_webrtc
4 years ago (2016-11-25 13:56:22 UTC) #5
phoglund
lgtm *crosses fingers*
4 years ago (2016-11-25 14:32:04 UTC) #6
ehmaldonado_webrtc
henrika: Just because you're an OWNER...
4 years ago (2016-11-25 14:34:38 UTC) #9
henrika_webrtc
I really don't know this code base at all. Hence, if you are uncertain about ...
4 years ago (2016-11-25 14:40:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2534593002/1
4 years ago (2016-11-25 14:45:34 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-25 14:47:13 UTC) #16
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/03d6b086df1e2571fd2b36d6a989f8c51becb6bc Cr-Commit-Position: refs/heads/master@{#15246}
4 years ago (2016-11-25 14:47:23 UTC) #18
ehmaldonado_webrtc
On 2016/11/25 14:47:23, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years ago (2016-11-25 14:47:53 UTC) #19
kjellander_webrtc
lgtm!
4 years ago (2016-11-28 07:02:09 UTC) #20
nisse-webrtc
It seems we still have webrtc/modules/audio_device/linux/latebindingsymboltable_linux.h, can we get rid of that too?
4 years ago (2016-12-13 13:41:44 UTC) #21
kjellander_webrtc
4 years ago (2016-12-13 13:47:04 UTC) #22
Message was sent while issue was closed.
On 2016/12/13 13:41:44, nisse-webrtc wrote:
> It seems we still have
> webrtc/modules/audio_device/linux/latebindingsymboltable_linux.h, can we get
rid
> of that too?

Edward is OOO for a couple of weeks. Feel free to take a stab.

Powered by Google App Engine
This is Rietveld 408576698