Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1107)

Unified Diff: webrtc/modules/video_capture/linux/device_info_linux.cc

Issue 2534553002: Replace VideoCaptureDataCallback by VideoSinkInterface. (Closed)
Patch Set: Drop inheritance of RefCountedModule. Drop tests of capture delay. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_capture/linux/device_info_linux.cc
diff --git a/webrtc/modules/video_capture/linux/device_info_linux.cc b/webrtc/modules/video_capture/linux/device_info_linux.cc
index ddcfe4bca1c6176246fdaf409ab44656463f051e..ce1d426031bce97a3569d4894f24c354949e72d8 100644
--- a/webrtc/modules/video_capture/linux/device_info_linux.cc
+++ b/webrtc/modules/video_capture/linux/device_info_linux.cc
@@ -28,13 +28,13 @@ namespace webrtc
namespace videocapturemodule
{
VideoCaptureModule::DeviceInfo*
-VideoCaptureImpl::CreateDeviceInfo(const int32_t id)
+VideoCaptureImpl::CreateDeviceInfo()
{
- return new videocapturemodule::DeviceInfoLinux(id);
+ return new videocapturemodule::DeviceInfoLinux();
}
-DeviceInfoLinux::DeviceInfoLinux(const int32_t id)
- : DeviceInfoImpl(id)
+DeviceInfoLinux::DeviceInfoLinux()
+ : DeviceInfoImpl()
{
}
@@ -49,7 +49,7 @@ DeviceInfoLinux::~DeviceInfoLinux()
uint32_t DeviceInfoLinux::NumberOfDevices()
{
- WEBRTC_TRACE(webrtc::kTraceApiCall, webrtc::kTraceVideoCapture, _id, "%s", __FUNCTION__);
+ WEBRTC_TRACE(webrtc::kTraceApiCall, webrtc::kTraceVideoCapture, 0, "%s", __FUNCTION__);
uint32_t count = 0;
char device[20];
@@ -78,7 +78,7 @@ int32_t DeviceInfoLinux::GetDeviceName(
char* /*productUniqueIdUTF8*/,
uint32_t /*productUniqueIdUTF8Length*/)
{
- WEBRTC_TRACE(webrtc::kTraceApiCall, webrtc::kTraceVideoCapture, _id, "%s", __FUNCTION__);
+ WEBRTC_TRACE(webrtc::kTraceApiCall, webrtc::kTraceVideoCapture, 0, "%s", __FUNCTION__);
// Travel through /dev/video [0-63]
uint32_t count = 0;
@@ -108,7 +108,7 @@ int32_t DeviceInfoLinux::GetDeviceName(
struct v4l2_capability cap;
if (ioctl(fd, VIDIOC_QUERYCAP, &cap) < 0)
{
- WEBRTC_TRACE(webrtc::kTraceError, webrtc::kTraceVideoCapture, _id,
+ WEBRTC_TRACE(webrtc::kTraceError, webrtc::kTraceVideoCapture, 0,
"error in querying the device capability for device %s. errno = %d",
device, errno);
close(fd);
@@ -127,7 +127,7 @@ int32_t DeviceInfoLinux::GetDeviceName(
}
else
{
- WEBRTC_TRACE(webrtc::kTraceError, webrtc::kTraceVideoCapture, _id, "buffer passed is too small");
+ WEBRTC_TRACE(webrtc::kTraceError, webrtc::kTraceVideoCapture, 0, "buffer passed is too small");
return -1;
}
@@ -142,7 +142,7 @@ int32_t DeviceInfoLinux::GetDeviceName(
}
else
{
- WEBRTC_TRACE(webrtc::kTraceError, webrtc::kTraceVideoCapture, _id,
+ WEBRTC_TRACE(webrtc::kTraceError, webrtc::kTraceVideoCapture, 0,
"buffer passed is too small");
return -1;
}
@@ -162,10 +162,10 @@ int32_t DeviceInfoLinux::CreateCapabilityMap(
(int32_t) strlen((char*) deviceUniqueIdUTF8);
if (deviceUniqueIdUTF8Length > kVideoCaptureUniqueNameLength)
{
- WEBRTC_TRACE(webrtc::kTraceError, webrtc::kTraceVideoCapture, _id, "Device name too long");
+ WEBRTC_TRACE(webrtc::kTraceError, webrtc::kTraceVideoCapture, 0, "Device name too long");
return -1;
}
- WEBRTC_TRACE(webrtc::kTraceInfo, webrtc::kTraceVideoCapture, _id,
+ WEBRTC_TRACE(webrtc::kTraceInfo, webrtc::kTraceVideoCapture, 0,
"CreateCapabilityMap called for device %s", deviceUniqueIdUTF8);
/* detect /dev/video [0-63] entries */
@@ -205,7 +205,7 @@ int32_t DeviceInfoLinux::CreateCapabilityMap(
if (!found)
{
- WEBRTC_TRACE(webrtc::kTraceError, webrtc::kTraceVideoCapture, _id, "no matching device found");
+ WEBRTC_TRACE(webrtc::kTraceError, webrtc::kTraceVideoCapture, 0, "no matching device found");
return -1;
}
@@ -224,7 +224,7 @@ int32_t DeviceInfoLinux::CreateCapabilityMap(
WEBRTC_TRACE(webrtc::kTraceInfo,
webrtc::kTraceVideoCapture,
- _id,
+ 0,
"CreateCapabilityMap %u",
static_cast<unsigned int>(_captureCapabilities.size()));
@@ -311,7 +311,7 @@ int32_t DeviceInfoLinux::FillCapabilities(int fd)
_captureCapabilities.push_back(cap);
index++;
- WEBRTC_TRACE(webrtc::kTraceInfo, webrtc::kTraceVideoCapture, _id,
+ WEBRTC_TRACE(webrtc::kTraceInfo, webrtc::kTraceVideoCapture, 0,
"Camera capability, width:%d height:%d type:%d fps:%d",
cap.width, cap.height, cap.rawType, cap.maxFPS);
}
@@ -321,7 +321,7 @@ int32_t DeviceInfoLinux::FillCapabilities(int fd)
WEBRTC_TRACE(webrtc::kTraceInfo,
webrtc::kTraceVideoCapture,
- _id,
+ 0,
"CreateCapabilityMap %u",
static_cast<unsigned int>(_captureCapabilities.size()));
return _captureCapabilities.size();

Powered by Google App Engine
This is Rietveld 408576698