Add a new UMA metric in APM to track incoming capture-side audio level

Add a new UMA metric in APM to track incoming capture-side audio level

This CL adds WebRTC.Audio.ApmCaptureInputLevelAverage and
WebRTC.Audio.ApmCaptureInputLevelPeak. The metrics are updated once
every 10 seconds.

BUG=webrtc:6622
Committed: https://crrev.com/290d43aa1406790132db794f81103922442c24c4
Cr-Commit-Position: refs/heads/master@{#15300}

[hlundin-webrtc, 2016-11-25 14:04:19]

Patchset #1 (id:1) has been deleted

[hlundin-webrtc, 2016-11-25 14:04:58]

henrik.lundin@webrtc.org changed reviewers:
+ peah@webrtc.org

[hlundin-webrtc, 2016-11-25 14:04:58]

Per, PTAL after the previous one.

[peah-webrtc, 2016-11-29 09:02:27]

Nice!

https://codereview.webrtc.org/2534473004/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/audio_processing_impl.cc (right):

https://codereview.webrtc.org/2534473004/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/audio_processing_impl.cc:1105: levels.average,
1, RMSLevel::kMinLevelDb, 100);
Why having a minimum value of 0? For a signal of maximum level the maximum value
is 0 dBFS.

https://codereview.webrtc.org/2534473004/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/audio_processing_impl.cc:1107: 1,
RMSLevel::kMinLevelDb, 100);
Why having a minimum value of 0? For a signal of maximum level the maximum value
is 0 dBFS.

[peah-webrtc, 2016-11-29 09:02:28]

Nice!

[peah-webrtc, 2016-11-29 09:02:29]

Nice!

[hlundin-webrtc, 2016-11-29 11:02:39]

https://codereview.webrtc.org/2534473004/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/audio_processing_impl.cc (right):

https://codereview.webrtc.org/2534473004/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/audio_processing_impl.cc:1105: levels.average,
1, RMSLevel::kMinLevelDb, 100);
On 2016/11/29 09:02:27, peah-webrtc wrote:
> Why having a minimum value of 0? For a signal of maximum level the maximum
value
> is 0 dBFS.

The value we get is between 0 and 127, which corresponds to 0 to -127 dBFS. And
since UMA histograms always create a zero-bucket anyway, the range [1, 127]
makes sense imo.

https://codereview.webrtc.org/2534473004/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/audio_processing_impl.cc:1107: 1,
RMSLevel::kMinLevelDb, 100);
On 2016/11/29 09:02:27, peah-webrtc wrote:
> Why having a minimum value of 0? For a signal of maximum level the maximum
value
> is 0 dBFS.

See above.

[hlundin-webrtc, 2016-11-29 11:03:55]

https://codereview.webrtc.org/2534473004/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/rms_level.h (right):

https://codereview.webrtc.org/2534473004/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/rms_level.h:35: static constexpr int kMinLevelDb
= 127;
Had to move this back out to the public part of the class.

[peah-webrtc, 2016-11-29 11:49:13]

On 2016/11/29 11:03:55, hlundin-webrtc wrote:
>
https://codereview.webrtc.org/2534473004/diff/40001/webrtc/modules/audio_proc...
> File webrtc/modules/audio_processing/rms_level.h (right):
> 
>
https://codereview.webrtc.org/2534473004/diff/40001/webrtc/modules/audio_proc...
> webrtc/modules/audio_processing/rms_level.h:35: static constexpr int
kMinLevelDb
> = 127;
> Had to move this back out to the public part of the class.

Awesome!

lgtm

[hlundin-webrtc, 2016-11-29 12:29:00]

The CQ bit was checked by henrik.lundin@webrtc.org

[commit-bot: I haz the power, 2016-11-29 12:29:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-29 12:37:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 12:37:03]

Try jobs failed on following builders:
  win_x64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/20103)

[hlundin-webrtc, 2016-11-29 15:43:06]

The CQ bit was checked by henrik.lundin@webrtc.org

[commit-bot: I haz the power, 2016-11-29 15:43:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-29 16:09:09]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480434186313610,
"parent_rev": "f56e3309cdc27d5086d8a40263fa4f2d1fa6c4f6", "commit_rev":
"f6fbf4f1ac88b2aed3d205872a5b225d7a195773"}

[commit-bot: I haz the power, 2016-11-29 16:09:14]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-11-29 16:09:21]

Description was changed from

==========
Add a new UMA metric in APM to track incoming capture-side audio level

This CL adds WebRTC.Audio.ApmCaptureInputLevelAverage and
WebRTC.Audio.ApmCaptureInputLevelPeak. The metrics are updated once
every 10 seconds.

BUG=webrtc:6622
==========

to

==========
Add a new UMA metric in APM to track incoming capture-side audio level

This CL adds WebRTC.Audio.ApmCaptureInputLevelAverage and
WebRTC.Audio.ApmCaptureInputLevelPeak. The metrics are updated once
every 10 seconds.

BUG=webrtc:6622

Committed: https://crrev.com/290d43aa1406790132db794f81103922442c24c4
Cr-Commit-Position: refs/heads/master@{#15300}
==========

[commit-bot: I haz the power, 2016-11-29 16:09:22]

Patchset 2 (id:??) landed as
https://crrev.com/290d43aa1406790132db794f81103922442c24c4
Cr-Commit-Position: refs/heads/master@{#15300}