Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2534093003: Calculate JitterBufferDelayInMs in the new jitter buffer. (Closed)

Created:
4 years ago by philipel
Modified:
4 years ago
Reviewers:
terelius, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Calculate JitterBufferDelayInMs in the new jitter buffer. JitterBufferDelayInMs is used for the WebRTC-NewVideoJitterBuffer finch experiment, and therefore needs to be calculated. BUG=webrtc:5514 Committed: https://crrev.com/be74270ebe61660e6f5512bc6eb5b200d7e334b4 Cr-Commit-Position: refs/heads/master@{#15313}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Feedback fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -9 lines) Patch
M webrtc/modules/video_coding/frame_buffer2.h View 2 chunks +10 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/frame_buffer2.cc View 4 chunks +18 lines, -3 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 1 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
philipel
4 years ago (2016-11-29 10:24:33 UTC) #2
terelius
https://codereview.webrtc.org/2534093003/diff/1/webrtc/video/receive_statistics_proxy.cc File webrtc/video/receive_statistics_proxy.cc (right): https://codereview.webrtc.org/2534093003/diff/1/webrtc/video/receive_statistics_proxy.cc#newcode96 webrtc/video/receive_statistics_proxy.cc:96: if (!(field_trial::FindFullName("WebRTC-NewVideoJitterBuffer") == Shouldn't we add some corresponding metric ...
4 years ago (2016-11-29 12:09:15 UTC) #3
philipel
https://codereview.webrtc.org/2534093003/diff/1/webrtc/video/receive_statistics_proxy.cc File webrtc/video/receive_statistics_proxy.cc (right): https://codereview.webrtc.org/2534093003/diff/1/webrtc/video/receive_statistics_proxy.cc#newcode96 webrtc/video/receive_statistics_proxy.cc:96: if (!(field_trial::FindFullName("WebRTC-NewVideoJitterBuffer") == On 2016/11/29 12:09:15, terelius wrote: > ...
4 years ago (2016-11-29 12:34:52 UTC) #4
terelius
lgtm
4 years ago (2016-11-29 12:59:53 UTC) #5
stefan-webrtc
lgtm
4 years ago (2016-11-29 17:50:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2534093003/20001
4 years ago (2016-11-30 09:30:07 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 09:31:43 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-30 09:31:52 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/be74270ebe61660e6f5512bc6eb5b200d7e334b4
Cr-Commit-Position: refs/heads/master@{#15313}

Powered by Google App Engine
This is Rietveld 408576698