Move ADM specific Android files into modules/audio_device/android/

Move ADM specific Android files into modules/audio_device/android/

- Move helpers_android.* and jvm_android.* from modules/utility/.

BUG=none
TBR=perkj@webrtc.org

Committed: https://crrev.com/e8d8a2bb9704beffed0780c7e0f3a9ef050ae97e
Cr-Commit-Position: refs/heads/master@{#15253}

[the sun, 2016-11-25 12:06:56]

solenberg@webrtc.org changed reviewers:
+ henrika@webrtc.org, perkj@webrtc.org

[henrika_webrtc, 2016-11-25 12:12:12]

LGTM

https://codereview.webrtc.org/2533573002/diff/20001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/android/helpers_android.h (right):

https://codereview.webrtc.org/2533573002/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/helpers_android.h:11: #ifndef
WEBRTC_MODULES_AUDIO_DEVICE_ANDROID_HELPERS_ANDROID_H_
Lots of Android here...

https://codereview.webrtc.org/2533573002/diff/20001/webrtc/voice_engine/voice...
File webrtc/voice_engine/voice_engine_impl.cc (left):

https://codereview.webrtc.org/2533573002/diff/20001/webrtc/voice_engine/voice...
webrtc/voice_engine/voice_engine_impl.cc:13: #include
"webrtc/modules/audio_device/android/audio_record_jni.h"
Nice ;-)

[the sun, 2016-11-25 18:45:58]

The CQ bit was checked by solenberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 18:46:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-25 19:07:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 19:07:30]

Dry run: This issue passed the CQ dry run.

[the sun, 2016-11-25 19:29:54]

https://codereview.webrtc.org/2533573002/diff/20001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/android/helpers_android.h (right):

https://codereview.webrtc.org/2533573002/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/helpers_android.h:11: #ifndef
WEBRTC_MODULES_AUDIO_DEVICE_ANDROID_HELPERS_ANDROID_H_
On 2016/11/25 12:12:11, henrika_webrtc wrote:
> Lots of Android here...

Yes, it looks like the internals of ADM for Android could benefit from some
further cleaning...

[the sun, 2016-11-25 19:30:46]

Description was changed from

==========
Move ADM specific Android files into modules/audio_device/android/

- Move helpers_android.* and jvm_android.* from modules/utility/.

BUG=none
==========

to

==========
Move ADM specific Android files into modules/audio_device/android/

- Move helpers_android.* and jvm_android.* from modules/utility/.

BUG=none
TBR=perkj@webrtc.org
==========

[the sun, 2016-11-25 19:30:51]

The CQ bit was checked by solenberg@webrtc.org

[commit-bot: I haz the power, 2016-11-25 19:31:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-25 19:34:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480102251636060,
"parent_rev": "afb36ae181abe264808feebcc4b9d11d1e25e0fe", "commit_rev":
"10b0c544c097285f71e0832bde435956baa039dd"}

[commit-bot: I haz the power, 2016-11-25 19:34:20]

Description was changed from

==========
Move ADM specific Android files into modules/audio_device/android/

- Move helpers_android.* and jvm_android.* from modules/utility/.

BUG=none
TBR=perkj@webrtc.org
==========

to

==========
Move ADM specific Android files into modules/audio_device/android/

- Move helpers_android.* and jvm_android.* from modules/utility/.

BUG=none
TBR=perkj@webrtc.org
==========

[commit-bot: I haz the power, 2016-11-25 19:34:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-25 19:34:32]

Description was changed from

==========
Move ADM specific Android files into modules/audio_device/android/

- Move helpers_android.* and jvm_android.* from modules/utility/.

BUG=none
TBR=perkj@webrtc.org
==========

to

==========
Move ADM specific Android files into modules/audio_device/android/

- Move helpers_android.* and jvm_android.* from modules/utility/.

BUG=none
TBR=perkj@webrtc.org

Committed: https://crrev.com/e8d8a2bb9704beffed0780c7e0f3a9ef050ae97e
Cr-Commit-Position: refs/heads/master@{#15253}
==========

[commit-bot: I haz the power, 2016-11-25 19:34:33]

Patchset 2 (id:??) landed as
https://crrev.com/e8d8a2bb9704beffed0780c7e0f3a9ef050ae97e
Cr-Commit-Position: refs/heads/master@{#15253}

[the sun, 2016-11-25 19:44:57]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/2531893002/ by solenberg@webrtc.org.

The reason for reverting is: Breaks downstream code.

[the sun, 2016-11-25 19:45:15]

Description was changed from

==========
Move ADM specific Android files into modules/audio_device/android/

- Move helpers_android.* and jvm_android.* from modules/utility/.

BUG=none
TBR=perkj@webrtc.org

Committed: https://crrev.com/e8d8a2bb9704beffed0780c7e0f3a9ef050ae97e
Cr-Commit-Position: refs/heads/master@{#15253}
==========

to

==========
Move ADM specific Android files into modules/audio_device/android/

- Move helpers_android.* and jvm_android.* from modules/utility/.

BUG=none
TBR=perkj@webrtc.org

Committed: https://crrev.com/e8d8a2bb9704beffed0780c7e0f3a9ef050ae97e
Cr-Commit-Position: refs/heads/master@{#15253}
==========

[henrika_webrtc, 2017-03-13 08:38:21]

FYI, this one still shows up as ongoing review for me. Not sure why.