Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2533543002: Roll chromium_revision 5e821a778b..5c22c2afac (432715:434448) (Closed)

Created:
4 years ago by ehmaldonado_webrtc
Modified:
4 years ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Testing #

Patch Set 3 : Disable c++1z-compat flag. #

Patch Set 4 : Rebase. Don't disable the flag anymore. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M build_overrides/build.gni View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
ehmaldonado_webrtc
What do you think?
4 years ago (2016-11-25 10:46:16 UTC) #4
kjellander_webrtc
lgtm
4 years ago (2016-11-25 16:45:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2533543002/120001
4 years ago (2016-11-25 16:47:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/3545)
4 years ago (2016-11-25 17:00:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2533543002/120001
4 years ago (2016-11-28 06:39:13 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_ubsan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan/builds/7218)
4 years ago (2016-11-28 06:56:04 UTC) #19
kjellander_webrtc
4 years ago (2016-11-28 09:04:38 UTC) #21 
On 2016/11/28 06:56:04, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_ubsan on master.tryserver.webrtc (JOB_FAILED,
> http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan/builds/7218)

I'm landing this as https://codereview.webrtc.org/2533733002/
Closing this CL.

Powered by Google App Engine
This is Rietveld 408576698