Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: webrtc/base/urlencode.cc

Issue 2533213005: Add File::Open / Create functions to take an rtc::Pathname (Closed)
Patch Set: Resolve review comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/pathutils.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/urlencode.cc
diff --git a/webrtc/base/urlencode.cc b/webrtc/base/urlencode.cc
index 8dc185dfb71ae357a1278b54ee9271a23d9923c6..bb508f46216ec5851bb2f0c605bf2a2924bc26d7 100644
--- a/webrtc/base/urlencode.cc
+++ b/webrtc/base/urlencode.cc
@@ -10,7 +10,7 @@
#include "webrtc/base/urlencode.h"
-#include "webrtc/base/common.h"
+#include "webrtc/base/checks.h"
#include "webrtc/base/stringutils.h"
static int HexPairValue(const char * code) {
@@ -114,7 +114,7 @@ int InternalUrlEncode(const char *source, char *dest, unsigned int max,
}
source++;
}
- ASSERT(static_cast<unsigned int>(dest - start) < max);
+ RTC_DCHECK_LT(static_cast<unsigned int>(dest - start), max);
*dest = 0;
return static_cast<int>(dest - start);
« no previous file with comments | « webrtc/base/pathutils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698