Add File::Open / Create functions to take an rtc::Pathname

webrtc/base/urlencode.cc

 /*
  *  Copyright 2008 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/base/urlencode.h"
 
-#include "webrtc/base/common.h"
+#include "webrtc/base/checks.h"
 #include "webrtc/base/stringutils.h"
 
 static int HexPairValue(const char * code) {
   int value = 0;
   for (const char * pch = code; pch < code + 2; ++pch) {
     value <<= 4;
     int digit = *pch;
     if (digit >= '0' && digit <= '9') {
       value += digit - '0';
     }
@@ skipping 83 matching lines @@
     } else {
       if (static_cast<unsigned>(dest - start) + 4 > max) {
         break;
       }
       *dest++ = '%';
       *dest++ = digits[(ch >> 4) & 0x0F];
       *dest++ = digits[       ch & 0x0F];
     }
     source++;
   }
-  ASSERT(static_cast<unsigned int>(dest - start) < max);
+  RTC_DCHECK(static_cast<unsigned int>(dest - start) < max);

[palmkvist, 2016/12/01 13:31:13]

RTC_DCHECK_LT

[Hzj_jie, 2016/12/06 22:33:07]

Done.

   *dest = 0;
 
   return static_cast<int>(dest - start);
 }
 
 int UrlEncode(const char *source, char *dest, unsigned max) {
   return InternalUrlEncode(source, dest, max, true, false);
 }
 
 int UrlEncodeWithoutEncodingSpaceAsPlus(const char *source, char *dest,
@@ skipping 44 matching lines @@
 UrlEncodeStringWithoutEncodingSpaceAsPlus(const std::string & decoded) {
   return InternalUrlEncodeString(decoded, false, false);
 }
 
 std::string
 UrlEncodeStringForOnlyUnsafeChars(const std::string & decoded) {
   return InternalUrlEncodeString(decoded, false, true);
 }
 
 }  // namespace rtc