Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2532993002: Revert of Pass time constant to bwe smoothing filter. (Closed)

Created:
4 years ago by ossu
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), Andrew MacDonald, zhengzhonghou_agora.io, henrika_webrtc, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, peah-webrtc, minyue-webrtc, the sun, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Pass time constant to bwe smoothing filter. (patchset #8 id:140001 of https://codereview.webrtc.org/2518923003/ ) Reason for revert: Unfortunately, this change breaks internal projects. Specifically the change to the CongestionController interface means anything implementing it will be forced to change in lock-step. Original issue's description: > Pass time constanct to bwe smoothing filter. > > BUG=webrtc:6443, webrtc:6303 > > Committed: https://crrev.com/9abbf5ae4ec7d688a9b4aa03a405f3faadb74b90 > Cr-Commit-Position: refs/heads/master@{#15266} TBR=minyue@webrtc.org,stefan@webrtc.org,solenberg@webrtc.org,michaelt@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6443, webrtc:6303 Committed: https://crrev.com/6287e82b9bc07fa9bb8474a1140f27d3b5660f8b Cr-Commit-Position: refs/heads/master@{#15272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -257 lines) Patch
M webrtc/audio/audio_send_stream.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/audio/audio_send_stream.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M webrtc/call/bitrate_allocator.h View 3 chunks +2 lines, -6 lines 0 comments Download
M webrtc/call/bitrate_allocator.cc View 4 chunks +4 lines, -9 lines 0 comments Download
M webrtc/call/bitrate_allocator_unittest.cc View 19 chunks +63 lines, -86 lines 0 comments Download
M webrtc/call/call.cc View 2 chunks +8 lines, -14 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller_unittest.cc View 7 chunks +16 lines, -28 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.h View 3 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.cc View 2 chunks +1 line, -6 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M webrtc/modules/congestion_controller/include/congestion_controller.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/congestion_controller/probing_interval_estimator.h View 1 chunk +5 lines, -7 lines 0 comments Download
M webrtc/modules/congestion_controller/probing_interval_estimator.cc View 2 chunks +6 lines, -11 lines 0 comments Download
M webrtc/modules/congestion_controller/probing_interval_estimator_unittest.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M webrtc/modules/congestion_controller/transport_feedback_adapter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/transport_feedback_adapter.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/test/fuzzers/congestion_controller_feedback_fuzzer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/test/mock_voe_channel_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/voice_engine/channel.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/channel.cc View 2 chunks +5 lines, -10 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/channel_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/voe_codec_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ossu
Created Revert of Pass time constant to bwe smoothing filter.
4 years ago (2016-11-28 16:04:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2532993002/1
4 years ago (2016-11-28 16:05:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 16:05:19 UTC) #5
commit-bot: I haz the power
4 years ago (2016-11-28 16:05:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6287e82b9bc07fa9bb8474a1140f27d3b5660f8b
Cr-Commit-Position: refs/heads/master@{#15272}

Powered by Google App Engine
This is Rietveld 408576698