Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 2532983006: Enable VideoToolbox encoder on mac (Closed)

Created:
4 years ago by kthelgason
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable VideoToolbox encoder on mac BUG=webrtc:6317 Committed: https://crrev.com/a974d76c74ce299492e56b95d03aaf26627897dd Cr-Commit-Position: refs/heads/master@{#15348}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -19 lines) Patch
M webrtc/sdk/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.cc View 4 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
kthelgason
4 years ago (2016-11-30 12:34:41 UTC) #2
magjed_webrtc
lgtm, great!
4 years ago (2016-11-30 12:53:14 UTC) #5
tkchin_webrtc
On 2016/11/30 12:53:14, magjed_webrtc wrote: > lgtm, great! progress here is great :) lgtm
4 years ago (2016-11-30 18:40:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2532983006/1
4 years ago (2016-12-01 08:15:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 08:16:54 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-01 08:16:59 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a974d76c74ce299492e56b95d03aaf26627897dd
Cr-Commit-Position: refs/heads/master@{#15348}

Powered by Google App Engine
This is Rietveld 408576698